Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidate code for json schema validation #913

Open
jeffbl opened this issue Nov 13, 2024 · 0 comments
Open

Consolidate code for json schema validation #913

jeffbl opened this issue Nov 13, 2024 · 0 comments
Assignees

Comments

@jeffbl
Copy link
Member

jeffbl commented Nov 13, 2024

All of the preprocessors (and likely handlers) repeat the same boilerplate code for all of the json schema checking. This is error-prone and bloats up the size of the preprocessors. This code should be consolidated into helper functions, or via some other method, so that simply specifying the schemas to be used is enough. This would also help with having to refactor in the future, e.g., for issue #912, where we want to change the schema error logging for all preprocessors and handlers.

  • create method for doing this
  • update all preprocessors/handlers to use this new code
  • make sure that builds are kicked off appropriately if this consolidated code is changed

Note that other such simplifications may present themselves. Anything we can do to avoid repeating the same code in multiple places should make it easier for developers to create and maintain IMAGE handlers and preprocessors. These should be logged as separate issues for discussion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants