Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addons that create macros #218

Open
FaileDestiny opened this issue Jul 19, 2024 · 2 comments
Open

Addons that create macros #218

FaileDestiny opened this issue Jul 19, 2024 · 2 comments

Comments

@FaileDestiny
Copy link

Addons that create macros such as AutoPotion, & RandomHearth create infinite macros

@Sakur909
Copy link

I have the same problem with Rested-XP. All available slots are being spammed with the generated macro from Rested-XP.

@phuze
Copy link

phuze commented Oct 7, 2024

Addons like AutoPotion interact with the game's default macro API by using global functions such as CreateMacro and EditMacro. These functions rely on macro names for identification.

MegaMacro, however, manages macros through its own system, using random IDs in place of the traditional names. As a result, when an addon like AutoPotion attempts to modify a macro named "AutoPotion," it can't locate it. This causes the addon to continually create new macros, leading to an infinite number being generated.

Ideally, MegaMacro should be redesigned to allow other addons to interface with the game's native macro system without issues. At the very least, it should provide public hooks that enable third-party addon developers to perform basic CRUD (create, read, update, delete) operations on macros by name. Since MegaMacro stores the macro names as DisplayName in its internal table, this should be achievable.

I personally use AutoPotion, and as such, I've submit a pull request to AutoPotion which adds compatibility support for MegaMacro. I won't do the same for the other addons you've mentioned, because I don't use them. That said, you're welcome to contact those addon developers, and have them reference my PR, to give them an idea of how they can add MegaMacro compatibility to their own addons.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants