Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[rb] Remove java date dependency #15122

Merged
merged 1 commit into from
Jan 20, 2025

Conversation

aguspe
Copy link
Contributor

@aguspe aguspe commented Jan 20, 2025

User description

Description

The java date dependency gives us issues with Bazel due to strip_prefix, this PR just remove the dependency from the gemfile.lock so it's possible to install

Motivation and Context

We want to be able to build the ruby docs for the latest release, a more permanent fix is under investigation

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

PR Type

Bug fix


Description

  • Removed the java date dependency from gemfile.lock to resolve issues with Bazel caused by strip_prefix.

  • Enables building Ruby docs for the latest release.

  • A more permanent fix is under investigation.


Changes walkthrough 📝

Relevant files

Need help?
  • Type /help how to ... in the comments thread for any question about Qodo Merge usage.
  • Check out the documentation for more information.
  • Copy link
    Contributor

    PR Code Suggestions ✨

    No code suggestions found for the PR.

    @diemol diemol merged commit e509cc3 into SeleniumHQ:trunk Jan 20, 2025
    21 of 23 checks passed
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    2 participants