Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sea-query-binder has time version <0.3.35 #772

Closed
jeremychone opened this issue Apr 19, 2024 · 1 comment
Closed

sea-query-binder has time version <0.3.35 #772

jeremychone opened this issue Apr 19, 2024 · 1 comment

Comments

@jeremychone
Copy link
Contributor

Description

In sea-query-binder version 0.6.0-rc.2,

in sea-query-binder, the time crate version is set as <0.3.35 (i.e., time = { version = "<0.3.35",...}).

Is there any reason for this?

It does cause some understandably unforeseen behavior when the lib/app code relies on 0.3.
It seems to work, but tools like cargo outdated completely break for example, and might have other side effects.

Steps to Reproduce

  1. Have sea-query with sea-query-binder with time
  2. have another time = "0.3' in the Cargo.toml
  3. cargo install cargo-outdated and then cargo outdated. The issue is that if this break, there might be more side effecs.

Expected Behavior

time set to version 0.3 or 0.3.35.

Actual Behavior

time set to version <0.3.35.

Versions

In sea-query-binder version 0.6.0-rc.2,

@tyt2y3
Copy link
Member

tyt2y3 commented Apr 19, 2024

See #766

@tyt2y3 tyt2y3 closed this as completed Apr 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants