Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rusqlite - bundled forces static linkage #754

Closed
majorfrog opened this issue Feb 16, 2024 · 2 comments
Closed

rusqlite - bundled forces static linkage #754

majorfrog opened this issue Feb 16, 2024 · 2 comments

Comments

@majorfrog
Copy link

Description

sea-query-rusqlite dependency rusqlite, states feature "bundled" which forces static linkage and automatically compile and link in an up to date version of SQLite.

It is not a default feature (for good reasons) and increases the binary size significantly.

It shopuld not be the default or it should be possible to state whether or not you want this behavior.

Expected Behavior

Should be possible to link against already present version of sqlite on the system.

Actual Behavior

Sqlite is built and statically linked.

Reproduces How Often

Always

Versions

sea-orm v0.12.10
sea-query v0.30.6

Additional Information

Dependency in
sea-query-rusqlite/Cargo.toml

@tyt2y3
Copy link
Member

tyt2y3 commented Feb 16, 2024

A PR would be appreciated to make it an optional feature.

@tyt2y3
Copy link
Member

tyt2y3 commented Feb 19, 2024

@tyt2y3 tyt2y3 closed this as completed Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants