From 87609b090c74e51c3941a925643ced051cd0a07a Mon Sep 17 00:00:00 2001 From: nicomiguelino Date: Tue, 31 Dec 2024 12:32:46 -0800 Subject: [PATCH 01/15] chore(ci): create a pipeline for linting YAML workflow files --- .github/workflows/lint-workflows.yml | 33 ++++++++++++++++++++++++++++ 1 file changed, 33 insertions(+) create mode 100644 .github/workflows/lint-workflows.yml diff --git a/.github/workflows/lint-workflows.yml b/.github/workflows/lint-workflows.yml new file mode 100644 index 000000000..5fbeecde3 --- /dev/null +++ b/.github/workflows/lint-workflows.yml @@ -0,0 +1,33 @@ +name: Lint GitHub Workflows + +on: + pull_request: + branches: + - master + paths: + - '**/*.yml' + - '**/*.yaml' + - '.github/workflows/lint-workflows.yml' + push: + branches: + - master + paths: + - '**/*.yml' + - '**/*.yaml' + - '.github/workflows/lint-workflows.yml' + +jobs: + actionlint: + runs-on: ubuntu-latest + steps: + - name: Checkout code + uses: actions/checkout@v4 + + - name: Install actionlint + run: | + bash <(curl https://raw.githubusercontent.com/rhysd/actionlint/main/scripts/download-actionlint.bash) + shell: bash + + - name: Run actionlint + run: ./actionlint -color + shell: bash \ No newline at end of file From a1ff30304b79d7384f2b3fc320f10751a7130866 Mon Sep 17 00:00:00 2001 From: nicomiguelino Date: Tue, 31 Dec 2024 19:36:36 -0800 Subject: [PATCH 02/15] chore(ci): resolve SC2086 --- .github/workflows/build-balena-disk-image.yaml | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/.github/workflows/build-balena-disk-image.yaml b/.github/workflows/build-balena-disk-image.yaml index deaa02996..7785cfdcd 100644 --- a/.github/workflows/build-balena-disk-image.yaml +++ b/.github/workflows/build-balena-disk-image.yaml @@ -37,15 +37,15 @@ jobs: - name: Get base board run: | if [ "${{ matrix.board }}" == 'pi1' ]; then - echo "BALENA_IMAGE=raspberry-pi" >> $GITHUB_ENV + echo "BALENA_IMAGE=raspberry-pi" >> "$GITHUB_ENV" elif [ "${{ matrix.board }}" == 'pi2' ]; then - echo "BALENA_IMAGE=raspberry-pi2" >> $GITHUB_ENV + echo "BALENA_IMAGE=raspberry-pi2" >> "$GITHUB_ENV" elif [ "${{ matrix.board }}" == 'pi3' ]; then - echo "BALENA_IMAGE=raspberrypi3" >> $GITHUB_ENV + echo "BALENA_IMAGE=raspberrypi3" >> "$GITHUB_ENV" elif [ "${{ matrix.board }}" == 'pi4' ]; then echo "BALENA_IMAGE=raspberrypi4-64" >> $GITHUB_ENV elif [ "${{ matrix.board }}" == 'pi5' ]; then - echo "BALENA_IMAGE=raspberrypi5" >> $GITHUB_ENV + echo "BALENA_IMAGE=raspberrypi5" >> "$GITHUB_ENV" fi - name: balena CLI Action - download From d28611a903cebf9196e3213c72b1813cd1e92502 Mon Sep 17 00:00:00 2001 From: nicomiguelino Date: Tue, 31 Dec 2024 19:47:01 -0800 Subject: [PATCH 03/15] chore(ci): resolve some more workflow linter comments --- .github/workflows/build-balena-disk-image.yaml | 2 +- .github/workflows/docker-build.yaml | 8 ++++---- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/.github/workflows/build-balena-disk-image.yaml b/.github/workflows/build-balena-disk-image.yaml index 7785cfdcd..69e2ba5f6 100644 --- a/.github/workflows/build-balena-disk-image.yaml +++ b/.github/workflows/build-balena-disk-image.yaml @@ -43,7 +43,7 @@ jobs: elif [ "${{ matrix.board }}" == 'pi3' ]; then echo "BALENA_IMAGE=raspberrypi3" >> "$GITHUB_ENV" elif [ "${{ matrix.board }}" == 'pi4' ]; then - echo "BALENA_IMAGE=raspberrypi4-64" >> $GITHUB_ENV + echo "BALENA_IMAGE=raspberrypi4-64" >> "$GITHUB_ENV" elif [ "${{ matrix.board }}" == 'pi5' ]; then echo "BALENA_IMAGE=raspberrypi5" >> "$GITHUB_ENV" fi diff --git a/.github/workflows/docker-build.yaml b/.github/workflows/docker-build.yaml index a29868dd3..e5eea0609 100644 --- a/.github/workflows/docker-build.yaml +++ b/.github/workflows/docker-build.yaml @@ -97,13 +97,13 @@ jobs: - name: Set Docker tag run: | - echo "GIT_SHORT_HASH=$(git rev-parse --short HEAD)" >> $GITHUB_ENV - echo "BOARD=${{ matrix.board }}" >> $GITHUB_ENV - echo "SHM_SIZE=256mb" >> $GITHUB_ENV + echo "GIT_SHORT_HASH=$(git rev-parse --short HEAD)" >> "$GITHUB_ENV" + echo "BOARD=${{ matrix.board }}" >> "$GITHUB_ENV" + echo "SHM_SIZE=256mb" >> "$GITHUB_ENV" - name: Prepare Balena file run: | - # Generage a docker-compose file for Balena with the correct board + # Generate a docker-compose file for Balena with the correct board mkdir -p balena-deploy # Copy in the Balena yaml file From 5cd6953bcfa1e6cc6dfb3da667d341b4ef4e4ba1 Mon Sep 17 00:00:00 2001 From: nicomiguelino Date: Tue, 31 Dec 2024 19:52:48 -0800 Subject: [PATCH 04/15] chore(ci): deploy some more workflow linter issues --- .github/workflows/build-webview.yaml | 4 ++-- .github/workflows/deploy-website.yaml | 2 +- .github/workflows/docker-build.yaml | 2 +- .github/workflows/generate-openapi-schema.yml | 2 +- 4 files changed, 5 insertions(+), 5 deletions(-) diff --git a/.github/workflows/build-webview.yaml b/.github/workflows/build-webview.yaml index c5de4b046..5e57d227e 100644 --- a/.github/workflows/build-webview.yaml +++ b/.github/workflows/build-webview.yaml @@ -25,7 +25,7 @@ jobs: - name: Login to DockerHub if: success() && github.event_name != 'pull_request' - uses: docker/login-action@v1 + uses: docker/login-action@v3 with: username: ${{ secrets.DOCKER_USERNAME }} password: ${{ secrets.DOCKER_PASSWORD }} @@ -98,7 +98,7 @@ jobs: docker exec -it qt-builder /webview/build_qt5.sh docker rm -f qt-builder - - uses: actions/upload-artifact@v3 + - uses: actions/upload-artifact@v4 with: name: Release files path: ~/tmp/qt-build/ diff --git a/.github/workflows/deploy-website.yaml b/.github/workflows/deploy-website.yaml index 552460426..a1af2ea30 100644 --- a/.github/workflows/deploy-website.yaml +++ b/.github/workflows/deploy-website.yaml @@ -31,7 +31,7 @@ jobs: uses: actions/checkout@v4 - name: Setup Pages - uses: actions/configure-pages@v2 + uses: actions/configure-pages@v5 - uses: actions/setup-python@v5 with: diff --git a/.github/workflows/docker-build.yaml b/.github/workflows/docker-build.yaml index e5eea0609..abe6a1065 100644 --- a/.github/workflows/docker-build.yaml +++ b/.github/workflows/docker-build.yaml @@ -73,7 +73,7 @@ jobs: - name: Login to DockerHub if: success() && github.event_name != 'pull_request' - uses: docker/login-action@v1 + uses: docker/login-action@v3 with: username: ${{ secrets.DOCKER_USERNAME }} password: ${{ secrets.DOCKER_PASSWORD }} diff --git a/.github/workflows/generate-openapi-schema.yml b/.github/workflows/generate-openapi-schema.yml index 3b0f1f3cb..9d0e48f92 100644 --- a/.github/workflows/generate-openapi-schema.yml +++ b/.github/workflows/generate-openapi-schema.yml @@ -105,7 +105,7 @@ jobs: --file anthias-api-schema.json - name: Upload the OpenAPI Schema - uses: actions/upload-artifact@v3 + uses: actions/upload-artifact@v4 with: name: anthias-api-schema path: anthias-api-schema.json From 032b1bf437f65b18aca655409880bbf28ee05fd9 Mon Sep 17 00:00:00 2001 From: nicomiguelino Date: Tue, 31 Dec 2024 19:57:04 -0800 Subject: [PATCH 05/15] chore(ci): fix some more workflow linter issues --- .github/workflows/deploy-website.yaml | 2 +- .github/workflows/generate-openapi-schema.yml | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/deploy-website.yaml b/.github/workflows/deploy-website.yaml index a1af2ea30..8e3da537e 100644 --- a/.github/workflows/deploy-website.yaml +++ b/.github/workflows/deploy-website.yaml @@ -73,4 +73,4 @@ jobs: steps: - name: Deploy to GitHub Pages id: deployment - uses: actions/deploy-pages@v1 + uses: actions/deploy-pages@v4 diff --git a/.github/workflows/generate-openapi-schema.yml b/.github/workflows/generate-openapi-schema.yml index 9d0e48f92..7b3f233d4 100644 --- a/.github/workflows/generate-openapi-schema.yml +++ b/.github/workflows/generate-openapi-schema.yml @@ -59,7 +59,7 @@ jobs: uses: actions/checkout@v4 - name: Set up Python 3.11 - uses: actions/setup-python@v3 + uses: actions/setup-python@v5 with: python-version: "3.11" @@ -77,7 +77,7 @@ jobs: poetry install --only=docker-image-builder - name: Cache Docker layers - uses: actions/cache@v3 + uses: actions/cache@v4 id: cache with: path: /tmp/.buildx-cache From 8362ad460cbdee88a0ba5a38e85974cba03648b0 Mon Sep 17 00:00:00 2001 From: nicomiguelino Date: Tue, 31 Dec 2024 20:17:49 -0800 Subject: [PATCH 06/15] chore(ci): fix some more workflow linter issues --- .github/workflows/deploy-website.yaml | 2 +- .github/workflows/docker-build.yaml | 2 +- .github/workflows/generate-openapi-schema.yml | 1 - .github/workflows/python-lint.yaml | 2 +- .github/workflows/sbom.yaml | 3 +++ 5 files changed, 6 insertions(+), 4 deletions(-) diff --git a/.github/workflows/deploy-website.yaml b/.github/workflows/deploy-website.yaml index 8e3da537e..aef1fb4bb 100644 --- a/.github/workflows/deploy-website.yaml +++ b/.github/workflows/deploy-website.yaml @@ -49,7 +49,7 @@ jobs: python bin/build-pi-imager-json.py > _site/rpi-imager.json # Make sure it's valid - cat _site/rpi-imager.json | jq + < _site/rpi-imager.json | jq # Copy in static files. This is to be migrated to Hugo later. cp -rf assets _site/ diff --git a/.github/workflows/docker-build.yaml b/.github/workflows/docker-build.yaml index abe6a1065..69fb30a65 100644 --- a/.github/workflows/docker-build.yaml +++ b/.github/workflows/docker-build.yaml @@ -110,7 +110,7 @@ jobs: cp balena.yml balena-deploy/ # Generate the docker-compose file - cat docker-compose.balena.yml.tmpl | \ + < docker-compose.balena.yml.tmpl | \ envsubst > balena-deploy/docker-compose.yml # Remove bind mounts to `/dev/vchiq` for Raspberry Pi 5 diff --git a/.github/workflows/generate-openapi-schema.yml b/.github/workflows/generate-openapi-schema.yml index 7b3f233d4..9b92744d6 100644 --- a/.github/workflows/generate-openapi-schema.yml +++ b/.github/workflows/generate-openapi-schema.yml @@ -39,7 +39,6 @@ on: description: 'Upload the OpenAPI schema as a release artifact' required: true type: boolean - default: false tag: description: 'Tag to be used for the release' required: true diff --git a/.github/workflows/python-lint.yaml b/.github/workflows/python-lint.yaml index eb3459d88..6cf86ab24 100644 --- a/.github/workflows/python-lint.yaml +++ b/.github/workflows/python-lint.yaml @@ -44,5 +44,5 @@ jobs: - name: Analyzing the code with flake8 run: | if [ -n "$(git ls-files '*.py')" ]; then - poetry run flake8 $(git ls-files '*.py') + poetry run flake8 "$(git ls-files '*.py')" fi diff --git a/.github/workflows/sbom.yaml b/.github/workflows/sbom.yaml index abfbcf588..16dd0d0ec 100644 --- a/.github/workflows/sbom.yaml +++ b/.github/workflows/sbom.yaml @@ -9,6 +9,9 @@ on: - 'poetry.lock' jobs: + run-tests: + uses: ./.github/workflows/docker-test.yaml + js-sbom: needs: run-tests runs-on: ubuntu-latest From fdd579714d12fa99c69d17b01663153b4afb915b Mon Sep 17 00:00:00 2001 From: nicomiguelino Date: Tue, 31 Dec 2024 20:44:14 -0800 Subject: [PATCH 07/15] chore(ci): fix some more workflow linter issues --- .github/workflows/build-webview.yaml | 14 +++++++------- .github/workflows/deploy-website.yaml | 2 +- .github/workflows/docker-build.yaml | 11 ++++++----- 3 files changed, 14 insertions(+), 13 deletions(-) diff --git a/.github/workflows/build-webview.yaml b/.github/workflows/build-webview.yaml index 5e57d227e..af4d7446f 100644 --- a/.github/workflows/build-webview.yaml +++ b/.github/workflows/build-webview.yaml @@ -33,13 +33,13 @@ jobs: - name: Set buildx arguments id: prepare run: | - echo ::set-output name=buildx_args::\ - --cache-from "screenly/ose-qt-builder:latest" \ - --output "type=image,push=true" \ - --build-arg "BUILD_DATE=$(date -u +'%Y-%m-%dT%H:%M:%SZ')" \ - --build-arg "GIT_HASH=$GITHUB_SHA" \ - --build-arg "GIT_SHORT_HASH=$(git rev-parse --short HEAD)" \ - --build-arg "GIT_BRANCH=$GITHUB_REF_NAME" + echo "buildx_args=\ + --cache-from \"screenly/ose-qt-builder:latest\" \ + --output \"type=image,push=true\" \ + --build-arg \"BUILD_DATE=$(date -u +'%Y-%m-%dT%H:%M:%SZ')\" \ + --build-arg \"GIT_HASH=$GITHUB_SHA\" \ + --build-arg \"GIT_SHORT_HASH=$(git rev-parse --short HEAD)\" \ + --build-arg \"GIT_BRANCH=$GITHUB_REF_NAME\"" >> "$GITHUB_OUTPUT" - name: Building container run: | diff --git a/.github/workflows/deploy-website.yaml b/.github/workflows/deploy-website.yaml index aef1fb4bb..cf49f7c6d 100644 --- a/.github/workflows/deploy-website.yaml +++ b/.github/workflows/deploy-website.yaml @@ -49,7 +49,7 @@ jobs: python bin/build-pi-imager-json.py > _site/rpi-imager.json # Make sure it's valid - < _site/rpi-imager.json | jq + jq . < _site/rpi-imager.json # Copy in static files. This is to be migrated to Hugo later. cp -rf assets _site/ diff --git a/.github/workflows/docker-build.yaml b/.github/workflows/docker-build.yaml index 69fb30a65..74789b420 100644 --- a/.github/workflows/docker-build.yaml +++ b/.github/workflows/docker-build.yaml @@ -97,9 +97,11 @@ jobs: - name: Set Docker tag run: | - echo "GIT_SHORT_HASH=$(git rev-parse --short HEAD)" >> "$GITHUB_ENV" - echo "BOARD=${{ matrix.board }}" >> "$GITHUB_ENV" - echo "SHM_SIZE=256mb" >> "$GITHUB_ENV" + { + echo "GIT_SHORT_HASH=$(git rev-parse --short HEAD)" + echo "BOARD=${{ matrix.board }}" + echo "SHM_SIZE=256mb" + } >> "$GITHUB_ENV" - name: Prepare Balena file run: | @@ -110,8 +112,7 @@ jobs: cp balena.yml balena-deploy/ # Generate the docker-compose file - < docker-compose.balena.yml.tmpl | \ - envsubst > balena-deploy/docker-compose.yml + envsubst < docker-compose.balena.yml.tmpl > balena-deploy/docker-compose.yml # Remove bind mounts to `/dev/vchiq` for Raspberry Pi 5 if [ "${{ matrix.board }}" == "pi5" ]; then From a2fe7f979181192035603a08d972e744e0efffdb Mon Sep 17 00:00:00 2001 From: nicomiguelino Date: Tue, 31 Dec 2024 20:46:14 -0800 Subject: [PATCH 08/15] chore(ci): fix Python linter workflow --- .github/workflows/python-lint.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/python-lint.yaml b/.github/workflows/python-lint.yaml index 6cf86ab24..eb3459d88 100644 --- a/.github/workflows/python-lint.yaml +++ b/.github/workflows/python-lint.yaml @@ -44,5 +44,5 @@ jobs: - name: Analyzing the code with flake8 run: | if [ -n "$(git ls-files '*.py')" ]; then - poetry run flake8 "$(git ls-files '*.py')" + poetry run flake8 $(git ls-files '*.py') fi From 80c03d92854ebd595fe6a724b8f5b09b87c0f540 Mon Sep 17 00:00:00 2001 From: nicomiguelino Date: Tue, 31 Dec 2024 20:49:25 -0800 Subject: [PATCH 09/15] chore(ci): fix Python linter workflow --- .github/workflows/python-lint.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/python-lint.yaml b/.github/workflows/python-lint.yaml index eb3459d88..a18740f6a 100644 --- a/.github/workflows/python-lint.yaml +++ b/.github/workflows/python-lint.yaml @@ -44,5 +44,5 @@ jobs: - name: Analyzing the code with flake8 run: | if [ -n "$(git ls-files '*.py')" ]; then - poetry run flake8 $(git ls-files '*.py') + git ls-files '*.py' | xargs poetry run flake8 fi From 27da407a51fba0f4840357e8a771115f53a879dd Mon Sep 17 00:00:00 2001 From: nicomiguelino Date: Wed, 15 Jan 2025 07:19:58 -0800 Subject: [PATCH 10/15] chore: revert trivial changes --- .github/workflows/python-lint.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/python-lint.yaml b/.github/workflows/python-lint.yaml index 6ca517126..35d1cd142 100644 --- a/.github/workflows/python-lint.yaml +++ b/.github/workflows/python-lint.yaml @@ -43,4 +43,4 @@ jobs: - name: Analyzing the code with ruff run: | - poetry run ruff check . + run ruff check . \ No newline at end of file From 09fbf2c0feed2f3011f0d13cda802ea211bbb960 Mon Sep 17 00:00:00 2001 From: nicomiguelino Date: Mon, 20 Jan 2025 13:48:31 -0800 Subject: [PATCH 11/15] fix: issue with the Python linting pipeline --- .github/workflows/python-lint.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/python-lint.yaml b/.github/workflows/python-lint.yaml index 35d1cd142..df9b72ae8 100644 --- a/.github/workflows/python-lint.yaml +++ b/.github/workflows/python-lint.yaml @@ -43,4 +43,4 @@ jobs: - name: Analyzing the code with ruff run: | - run ruff check . \ No newline at end of file + poetry ruff check . From ddc10ceaf1d2b48e3b621f91f84dad627817245f Mon Sep 17 00:00:00 2001 From: nicomiguelino Date: Mon, 20 Jan 2025 13:53:13 -0800 Subject: [PATCH 12/15] chore: resolve linting errors --- .github/workflows/docker-build.yaml | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/.github/workflows/docker-build.yaml b/.github/workflows/docker-build.yaml index f87c6bbc2..8f2e91440 100644 --- a/.github/workflows/docker-build.yaml +++ b/.github/workflows/docker-build.yaml @@ -109,15 +109,15 @@ jobs: - name: Set Docker tag run: | - echo "GIT_SHORT_HASH=$(git rev-parse --short HEAD)" >> $GITHUB_ENV + echo "GIT_SHORT_HASH=$(git rev-parse --short HEAD)" >> "$GITHUB_ENV if [ "${{ matrix.board }}" == "pi4" ]; then - echo "BOARD=${{ matrix.board }}-64" >> $GITHUB_ENV + echo "BOARD=${{ matrix.board }}-64" >> "$GITHUB_ENV" else - echo "BOARD=${{ matrix.board }}" >> $GITHUB_ENV + echo "BOARD=${{ matrix.board }}" >> "$GITHUB_ENV" fi - echo "SHM_SIZE=256mb" >> $GITHUB_ENV + echo "SHM_SIZE=256mb" >> "$GITHUB_ENV" - name: Prepare Balena file run: | From 26f4fe45b8f426b0b6dd371abf7c6e014e9f1e6d Mon Sep 17 00:00:00 2001 From: nicomiguelino Date: Mon, 20 Jan 2025 13:58:04 -0800 Subject: [PATCH 13/15] chore(ci): fix the Python linting pipeline --- .github/workflows/python-lint.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/python-lint.yaml b/.github/workflows/python-lint.yaml index df9b72ae8..6ca517126 100644 --- a/.github/workflows/python-lint.yaml +++ b/.github/workflows/python-lint.yaml @@ -43,4 +43,4 @@ jobs: - name: Analyzing the code with ruff run: | - poetry ruff check . + poetry run ruff check . From 0ed98c0a653de84b7e8ae549078a3689f5c982d8 Mon Sep 17 00:00:00 2001 From: nicomiguelino Date: Mon, 20 Jan 2025 14:00:22 -0800 Subject: [PATCH 14/15] chore(ci): resolve workflow syntax errors --- .github/workflows/docker-build.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/docker-build.yaml b/.github/workflows/docker-build.yaml index 8f2e91440..1b3fa080b 100644 --- a/.github/workflows/docker-build.yaml +++ b/.github/workflows/docker-build.yaml @@ -109,7 +109,7 @@ jobs: - name: Set Docker tag run: | - echo "GIT_SHORT_HASH=$(git rev-parse --short HEAD)" >> "$GITHUB_ENV + echo "GIT_SHORT_HASH=$(git rev-parse --short HEAD)" >> "$GITHUB_ENV" if [ "${{ matrix.board }}" == "pi4" ]; then echo "BOARD=${{ matrix.board }}-64" >> "$GITHUB_ENV" From 0aeae7b9da1b9b5bdc99abe6da63e299017023c2 Mon Sep 17 00:00:00 2001 From: nicomiguelino Date: Thu, 23 Jan 2025 11:57:38 -0800 Subject: [PATCH 15/15] chore(ci): refactor workflow file used for building WebView --- .github/workflows/build-webview.yaml | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/.github/workflows/build-webview.yaml b/.github/workflows/build-webview.yaml index 07bd5d170..29bd864f7 100644 --- a/.github/workflows/build-webview.yaml +++ b/.github/workflows/build-webview.yaml @@ -33,13 +33,14 @@ jobs: - name: Set buildx arguments id: prepare run: | - echo "buildx_args=\ - --cache-from \"screenly/ose-qt-builder:latest\" \ + { + echo "buildx_args=--cache-from \"screenly/ose-qt-builder:latest\" \ --output \"type=image,push=true\" \ --build-arg \"BUILD_DATE=$(date -u +'%Y-%m-%dT%H:%M:%SZ')\" \ --build-arg \"GIT_HASH=$GITHUB_SHA\" \ --build-arg \"GIT_SHORT_HASH=$(git rev-parse --short HEAD)\" \ - --build-arg \"GIT_BRANCH=$GITHUB_REF_NAME\"" >> "$GITHUB_OUTPUT" + --build-arg \"GIT_BRANCH=$GITHUB_REF_NAME\"" + } >> "$GITHUB_OUTPUT" - name: Building container run: |