-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade from Version 1.4.0 --> 1.4.2 introduces rb-gsl dependency, downgrades spreadsheet #28
Comments
In commit 8ce01 I removed the dependency on rb-gsl and pushed a new version (1.4.3) to rubygems. I also updated Minimization. Everything should be working right now. :P Thank you for these issues! |
Very cool, thx. Any thoughts on why the |
Not really. I refactored I opened #29 to work on this. Nothing is broken right now, but leaving it outdated doesn't seem like a good idea... |
Cool, thx!! |
[As mentioned in my issue in the old repo]…
It appears that going from
1.4.0
to1.4.2
creates some unexpected dependency changes that should not be a part of a Patch-level release:rb-gsl
gem is now required. This is problematic on Heroku where it cannot be easily built.spreadsheet
gem gets pinned to an older Minor release; on my app this mandated a downgrade ofspreadsheet
from0.9.9
to0.6.9
. Not sure if this is intentional or matters, but it was surprising if nothing else.minimization
gem is not pinned to0.2.1
a similar dependency is created with the bump to0.2.2
. I have opened an issue over there.Here's a peek at the diff of Gemfile.lock when
statsample ~> 1.4.0
andmimization = 0.2.1
:The text was updated successfully, but these errors were encountered: