Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade from Version 1.4.0 --> 1.4.2 introduces rb-gsl dependency, downgrades spreadsheet #28

Closed
rdlugosz opened this issue Apr 23, 2015 · 4 comments

Comments

@rdlugosz
Copy link

[As mentioned in my issue in the old repo]…

It appears that going from 1.4.0 to 1.4.2 creates some unexpected dependency changes that should not be a part of a Patch-level release:

  1. The rb-gsl gem is now required. This is problematic on Heroku where it cannot be easily built.
  2. The spreadsheet gem gets pinned to an older Minor release; on my app this mandated a downgrade of spreadsheet from 0.9.9 to 0.6.9. Not sure if this is intentional or matters, but it was surprising if nothing else.
  3. If the minimization gem is not pinned to 0.2.1 a similar dependency is created with the bump to 0.2.2. I have opened an issue over there.

Here's a peek at the diff of Gemfile.lock when statsample ~> 1.4.0 and mimization = 0.2.1:

-    statsample (1.4.0)
-      dirty-memoize (~> 0.0)
+    statsample (1.4.2)
+      awesome_print
+      dirty-memoize
       distribution
-      extendmatrix (~> 0.3.1)
-      fastercsv (> 0)
-      minimization (~> 0.2.0)
+      extendmatrix
+      minimization
+      rb-gsl
       reportbuilder (~> 1.4)
       rserve-client
-      rubyvis
-      spreadsheet (~> 0.6)
-      statsample-bivariate-extension (> 0)
-    statsample-bivariate-extension (1.1.0)
-      distribution (~> 0.6)
+      rubyvis (~> 0.5.0)
+      spreadsheet (~> 0.6.5)
@agarie
Copy link
Member

agarie commented Apr 27, 2015

In commit 8ce01 I removed the dependency on rb-gsl and pushed a new version (1.4.3) to rubygems.

I also updated Minimization. Everything should be working right now. :P

Thank you for these issues!

@agarie agarie closed this as completed Apr 27, 2015
@rdlugosz
Copy link
Author

Very cool, thx. Any thoughts on why the spreadsheet gem is being pinned to the 0.6 version? More of a curiosity, but previously we were at 0.9.9 and their most current release is 1.0.3.

@agarie
Copy link
Member

agarie commented Apr 27, 2015

Not really. I refactored statsample to use a gemspec instead of hoe and the rb-gsl dep was introduced by mistake -- I was using it anyway on my system and Travis already installed it. Thankfully you and other folks complained and it's fixed now. I had that version of spreadsheet installed here and it didn't break anything, so I pinned it.

I opened #29 to work on this. Nothing is broken right now, but leaving it outdated doesn't seem like a good idea...

@rdlugosz
Copy link
Author

Cool, thx!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants