From 25bed204914b9e175b8fc16528b9e16b904f91c4 Mon Sep 17 00:00:00 2001 From: Adam Ruberti <5392248+ariwk@users.noreply.github.com> Date: Tue, 30 Apr 2024 16:18:19 +0200 Subject: [PATCH] chore: update CONTRIBUTING.md for better readability --- CONTRIBUTING.md | 74 +++++++++++++++++++------------------------------ 1 file changed, 28 insertions(+), 46 deletions(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 1b2d63a..1d30b4c 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -7,77 +7,68 @@ These are mostly guidelines, not rules. Use your best judgment, and feel free to [Prerequisites](#prerequisites) -[I just have a question!](#i-just-have-a-question) +[Ask a question](#ask-a-question) [What should I know before I get started?](#what-should-i-know-before-i-get-started) * [Tools and Packages](#tools-and-packages) * [Design Decisions](#design-decisions) [How Can I Contribute?](#how-can-i-contribute) -* [Issues and Bugs](#issue) -* [Feature Requests](#feature) +- [Commit Message Guidelines](#commit) +* [Reporting Bugs](#bugs) +* [Suggesting Enhancements](#enhancements) +* [Submitting Changes](#submit-pr) * [Pull Requests Guidelines](#submit-pr) -* [Submitting a Pull Request (PR)](#submit-pr) * [Coding Rules](#rules) -* [Commit Message Guidelines](#commit) -* [Your First Code Contribution](#your-first-code-contribution) - ## Code of Conduct This project and everyone participating in it are governed by our [Code of Conduct](CODE_OF_CONDUCT.md). By participating, you are expected to uphold this code. Please report unacceptable behavior to [polarion-opensource(at)sbb.ch]. - +#ToDo --> should we expose our email? ## Prerequisites All contributors must have an active Polarion license. An active Polarion license means that the contributor has access to a valid Polarion license issued by Siemens, including but not limited to customer, partner, academic, trial, or demo Polarion license. - -## I just have a question! +## Asking questions +#ToDo --> discussion or issue? Join the conversation! Please ask questions in the discussions [here](../../discussions) +We use GitHub for tracking bugs and feature requests related to this extension. +Do not know how something in this project works? Curious if this project can achieve your desired functionality? Please [submit an issue](../../issues/new) with the label `question`. ## What should I know before I get started? ### Tools and Packages All extensions provided by SBB Polarion Team can be built, tested and packaged using Maven. It is only possible when the dependencies are extract from Polarion installer. The process must be performed by each contributor. Please consider to use **TODO --> ADD LINK TO OUR PYTHON UTILITY** to extract the dependencies for your own Polarion installer version. - ### Design Decisions -The common implementation for each extension provided by SBB Polarion Team is located in [ch.sbb.polarion.extension.generic](https://github.com/SchweizerischeBundesbahnen/ch.sbb.polarion.extension.generic) - +The common implementation for extensions provided by SBB Polarion Team is located in [ch.sbb.polarion.extension.generic](https://github.com/SchweizerischeBundesbahnen/ch.sbb.polarion.extension.generic) ## How Can I Contribute? -### Issues and Bugs -If you find a bug in the source code or a mistake in the documentation, you can help us by [submitting an issue](#submit-issue) to our [GitHub Repository](../../issues/new). Including an issue reproduction (via StackBlitz, JsBin, Plunkr, etc.) is the absolute best way to help the team quickly diagnose the problem. Screenshots are also helpful. - -You can help the team even more and [submit a Pull Request](#submit-pr) with a fix. - -### Feature Request -You can *request* a new feature by [submitting an issue](#submit-issue) to our [GitHub Repository](../../issues/new). -If you would like to *implement* a new feature, please submit an issue with -a proposal for your work first, to be sure that we can use it. -Please consider what kind of change it is: - -* For a **Major Feature**, first open an issue and outline your proposal so that it can be - discussed. This will also allow us to better coordinate our efforts, prevent duplication of work, - and help you to craft the change so that it is successfully accepted into the project. -* **Small Features** can be crafted and directly [submitted as a Pull Request](#submit-pr). +### Commit Message Guidelines +This project uses [Conventional Commits](https://www.conventionalcommits.org/) to generate the Changelog using the [Release Please GitHub action](.github/workflows/release-please.yml) +For comprehensive information, please consult the [Release Please documentation](https://github.com/googleapis/release-please). +### Reporting Bugs +To report a bug, [submit an issue](../../issues/new) with the label `bug`. Please ensure the bug has not already been reported. **If the bug is a potential security vulnerability, please report it using our [security policy](./SECURITY.md).** -### Submitting an Issue -If your issue appears to be a bug, and hasn't been reported, open a new issue. -Providing the following information will increase the -chances of your issue being dealt with quickly: +Providing the following information will increase the chances of your issue being dealt with quickly: * **Overview of the Issue** - if an error is being thrown a non-minified stack trace helps * **Toolchain and Environment Details** - which versions of libraries, toolchain, platform etc * **Motivation for or Use Case** - explain what are you trying to do and why the current behavior is a bug for you * **Browsers and Operating System** - is this a problem with all browsers? -* **Reproduce the Error** - provide a live example (using StackBlitz or similar) or a unambiguous set of steps -* **Screenshots** - maybe screenshots can help the team - triage issues far more quickly than a text description. +* **Reproduce the Error** - provide a live example or a unambiguous set of steps +* **Screenshots** - maybe screenshots can help the team to triage issues far more quickly than a text description * **Related Issues** - has a similar issue been reported before? * **Suggest a Fix** - if you can't fix the bug yourself, perhaps you can point to what might be causing the problem (line of code or commit) -You can file new issues by providing the above information [here](../../issues/new). +You can help the team even more by [submitting a Pull Request](#submit-pr) with a fix. +### Suggesting Enhancements +To suggest a feature or enhancement, please [submit an issue](../../issues/new) with the label `enhancement`. Please ensure the feature or enhancement has not already been suggested. + +Please consider what kind of change it is: + +* For a **Major Feature**, first open an issue and outline your proposal so that it can be discussed. This will also allow us to better coordinate our efforts, prevent duplication of work, and help you to craft the change so that it is successfully accepted into the project. +* **Small Features** can be crafted and directly [submitted as a Pull Request](#submit-pr). -### Submitting a Pull Request (PR) +### Submitting Changes Before you submit your Pull Request (PR) consider the following guidelines: * Make your changes in a new git branch: @@ -115,12 +106,3 @@ To ensure consistency throughout the source code, keep these rules in mind as yo * All public API methods **must be documented**. * Also see [CODING_STANDARDS](./CODING_STANDARDS.md) -### Commit Message Guidelines -This project uses [Conventional Commits](https://www.conventionalcommits.org/) to generate the Changelog using the [Release Please GitHub action](.github/workflows/release-please.yml) -For comprehensive information, please consult the [Release Please documentation](https://github.com/googleapis/release-please). - -### Your First Code Contribution -Unsure where to begin contributing to Atom? You can start by looking through these `beginner` and `help-wanted` issues: - -* [Beginner issues][beginner] - issues which should only require a few lines of code, and a test or two. -* [Help wanted issues][help-wanted] - issues which should be a bit more involved than `beginner` issues.