Feat: Edition dropdown #546
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for keen-banoffee-86ed50 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Did you check also the mobile version? |
|
Yup, mobile version is also addressed in the PR I decided against going for a dropdown in the menu, so I just added a sub category to the "Editions" title EDIT: Updated the style, look at comment blow
|
|
Addressed again the mobile styles since they were bothering me
|
|
From desktop the link is working only if I click on the text and not if I'm clicking on the box |
|
^^ Same in mobile |
|
Good catch @TheJoin95, fixed it :) |
TheJoin95
approved these changes
Dec 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses https://github.com/Schroedinger-Hat/schroedinger-hat/issues/304