Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update filematch for deployer #4283

Merged

Conversation

derrik-fleming
Copy link
Contributor

When trying to create a GitHub workflow for deployment (at .github/workflows/deploy.yml) this file match got in the way.

Copy link
Contributor

Thanks for the PR!

This section of the codebase is owned by @madskristensen and @hyperupcall - if they write a comment saying "LGTM" then it will be merged.

@hyperupcall
Copy link
Member

hyperupcall commented Dec 16, 2024

@derrik-fleming I'm OK with removing these file matches. Wondering, is .deployer/** a common convention for the tool? I couldn't find any reference to it in its documentation

@derrik-fleming
Copy link
Contributor Author

You got me, I looked too prior to opening the PR. I don't use the tool personally, but it seems like a common practice with many other tools so I didn't think it was too far of a reach.

Happy to update with any suggestions that would remove collisions.

@hyperupcall
Copy link
Member

True that many other tools use directory names that match .<toolName>, but I am also hesitant to add fileMatches that aren't conventionally used. I can accept setting the fileMatch to an empty array to remove potential conflicts!

@derrik-fleming
Copy link
Contributor Author

@hyperupcall Sure, that makes sense. I've updated my commit.

@hyperupcall
Copy link
Member

Great, thanks!

@hyperupcall hyperupcall merged commit 1b05633 into SchemaStore:master Dec 29, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants