Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update catalog.json #3983

Closed
wants to merge 2 commits into from
Closed

Conversation

BlackwallDaemon
Copy link
Contributor

Fix Versions for Semgrep

Fix Versions for Semgrep
Copy link
Contributor

Thanks for the PR!

This section of the codebase is owned by @madskristensen and @hyperupcall - if they write a comment saying "LGTM" then it will be merged.

@hyperupcall
Copy link
Member

hyperupcall commented Aug 11, 2024

Thanks - shouldn't all the versions continue to exist? They still work for me

@BlackwallDaemon
Copy link
Contributor Author

@hyperupcall They should - it's all a matter of the version in the url, But it's always the latest one so no need for them.

@hyperupcall
Copy link
Member

@BlackwallDaemon Does semgrep.json currently fail to resolve/redirect to the schema? I worry that with this change, the "canonical" URL will be written in two different places and has the potential to go out of sync

@BlackwallDaemon
Copy link
Contributor Author

@BlackwallDaemon Does semgrep.json currently fail to resolve/redirect to the schema? I worry that with this change, the "canonical" URL will be written in two different places and has the potential to go out of sync

Currently the semgrep.json always will be the latest one so long it's from their repo. What do you mean by out of sync?

@hyperupcall
Copy link
Member

hyperupcall commented Aug 21, 2024

By out of sync, I mean that this value and this value (from your proposed change) will have the potential to be different. That is, an IDE finding the correct schema for a semgrep.json file, and a user quering the website for json.schemastore.com/json/schema.json will potentially return schemas with different structures). That's why the ref "$ref" exists - it keeps a single source of truth while preserving compatibility.

So what I mean, is that semgrep.json should not be changed because it can potentially "be out of sync", unless there is a more important issue at play

@hyperupcall
Copy link
Member

hyperupcall commented Aug 21, 2024

So unless I'm mistaken by anything, I'll be closing this issue

@BlackwallDaemon
Copy link
Contributor Author

So unless I'm mistaken by anything, I'll be closing this issue

You can merge them - they are the same schema basically

BlackwallDaemon added a commit to BlackwallDaemon/schemastore that referenced this pull request Sep 11, 2024
Notice SchemaStore#3983

Add semgrep schemas
madskristensen pushed a commit that referenced this pull request Sep 11, 2024
Notice #3983

Add semgrep schemas
benpops89 pushed a commit to benpops89/schemastore that referenced this pull request Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants