Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please rename master branch to main #2121

Open
ssbarnea opened this issue Mar 4, 2022 · 6 comments
Open

Please rename master branch to main #2121

ssbarnea opened this issue Mar 4, 2022 · 6 comments
Labels
enhancement:build-server Propose something new for the SchemaStore web site or build server. (auto-generated by issue forms)

Comments

@ssbarnea
Copy link
Contributor

ssbarnea commented Mar 4, 2022

Description of the feature / enhancement.

Apparently schemastore is one of the last project I usually contribute to which did not make the rename of master to main, so please do the rename.

As GitHub is quite good with redirects, I doubt this move would create any problems.

Are you making a PR for this?

No, someone else must create the PR.

@ssbarnea ssbarnea added the enhancement:build-server Propose something new for the SchemaStore web site or build server. (auto-generated by issue forms) label Mar 4, 2022
@marcusrbrown
Copy link
Contributor

Seconded, please rename the master branch to main.

@hyperupcall
Copy link
Member

hyperupcall commented Jan 31, 2023

I'm for this as well. GitHub is great with redirects, but if extra precaution is wanted, we can always have master be a separate, non-default branch for compatibility for a certain amount of time.

@ssbarnea
Copy link
Contributor Author

@hyperupcall In fact keeping a master branch would be worse because it will break users. When the branch is renamed on github, they add an alias for compatibility. If you create a branch named master, that no longer works and you have a source of confusion.

@hyperupcall
Copy link
Member

I see - thank you. Then it would be better to do a straight rename :)

@rdwz
Copy link

rdwz commented Sep 8, 2023

Both Conservancy and the Git project are aware that the initial branch name, ‘master’, is offensive to some people and we empathize with those hurt by the use of that term.

https://sfconservancy.org/news/2020/jun/23/gitbranchname/

Renaming a branch will:

Re-target any open pull requests
Update any draft releases based on the branch
Move any branch protection rules that explicitly reference the old name
Update the branch used to build GitHub Pages, if applicable
Show a notice to repository contributors, maintainers, and admins on the repository homepage with instructions to update local copies of the repository
Show a notice to contributors who git push to the old branch
Redirect web requests for the old branch name to the new branch name
Return a "Moved Permanently" response in API requests for the old branch name

https://github.com/github/renaming

@okineadev
Copy link
Contributor

I agree with that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement:build-server Propose something new for the SchemaStore web site or build server. (auto-generated by issue forms)
Projects
None yet
Development

No branches or pull requests

5 participants