From 8f7a8c438645e5294dc85a1caf8d793283e0f410 Mon Sep 17 00:00:00 2001 From: Savindu Dimal Date: Mon, 23 Sep 2024 17:01:56 +0530 Subject: [PATCH] Fix db connection pool exhausting issue --- .../org/wso2/carbon/apimgt/impl/dao/ApiMgtDAO.java | 13 ++++++------- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/components/apimgt/org.wso2.carbon.apimgt.impl/src/main/java/org/wso2/carbon/apimgt/impl/dao/ApiMgtDAO.java b/components/apimgt/org.wso2.carbon.apimgt.impl/src/main/java/org/wso2/carbon/apimgt/impl/dao/ApiMgtDAO.java index 91eac19f8dca..421584e3f931 100644 --- a/components/apimgt/org.wso2.carbon.apimgt.impl/src/main/java/org/wso2/carbon/apimgt/impl/dao/ApiMgtDAO.java +++ b/components/apimgt/org.wso2.carbon.apimgt.impl/src/main/java/org/wso2/carbon/apimgt/impl/dao/ApiMgtDAO.java @@ -14720,13 +14720,12 @@ private List buildUpdateParams(LLMProvider provider) { public LLMProvider getLLMProvider(String organization, String llmProviderId) throws APIManagementException { String errorMessage = "Failed to get LLM Provider in tenant domain: " + organization; - try { - Connection connection = APIMgtDBUtil.getConnection(); - String getLlmProviderSql = SQLConstants.GET_LLM_PROVIDER_SQL; - if (organization != null) { - getLlmProviderSql += " AND ORGANIZATION = ?"; - } - PreparedStatement preparedStatement = connection.prepareStatement(getLlmProviderSql); + String getLlmProviderSql = SQLConstants.GET_LLM_PROVIDER_SQL; + if (organization != null) { + getLlmProviderSql += " AND ORGANIZATION = ?"; + } + try (Connection connection = APIMgtDBUtil.getConnection(); + PreparedStatement preparedStatement = connection.prepareStatement(getLlmProviderSql)) { preparedStatement.setString(1, llmProviderId); if (organization != null) { preparedStatement.setString(2, organization);