From 89f540ff076bad852742af720647e41c336852a4 Mon Sep 17 00:00:00 2001 From: Peter Ondrejka Date: Wed, 5 Feb 2025 10:22:35 +0100 Subject: [PATCH] non existent APIResponseError (#17406) (cherry picked from commit 233873c7cd67c478bfe9784dbf96e4e1c9ffc2e1) --- robottelo/exceptions.py | 4 ++++ robottelo/host_helpers/api_factory.py | 13 ++++++------- 2 files changed, 10 insertions(+), 7 deletions(-) diff --git a/robottelo/exceptions.py b/robottelo/exceptions.py index 882befc1619..0748431196f 100644 --- a/robottelo/exceptions.py +++ b/robottelo/exceptions.py @@ -1,6 +1,10 @@ """Custom Errors for Robottelo""" +class APIResponseError(Exception): + """Indicates wrong API response""" + + class GCECertNotFoundError(Exception): """An exception to raise when GCE Cert json is not available for creating GCE CR""" diff --git a/robottelo/host_helpers/api_factory.py b/robottelo/host_helpers/api_factory.py index b1feb836a12..db637141b93 100644 --- a/robottelo/host_helpers/api_factory.py +++ b/robottelo/host_helpers/api_factory.py @@ -17,6 +17,7 @@ DEFAULT_ARCHITECTURE, REPO_TYPE, ) +from robottelo.exceptions import APIResponseError from robottelo.host_helpers.repository_mixins import initiate_repo_helpers @@ -206,14 +207,14 @@ def create_role_permissions( query={'search': f'name="{name}"'} ) if not result: - raise self._satellite.api.APIResponseError(f'permission "{name}" not found') + raise APIResponseError(f'permission "{name}" not found') if len(result) > 1: - raise self._satellite.api.APIResponseError( + raise APIResponseError( f'found more than one entity for permission "{name}"' ) entity_permission = result[0] if entity_permission.name != name: - raise self._satellite.api.APIResponseError( + raise APIResponseError( 'the returned permission is different from the' f' requested one "{entity_permission.name} != {name}"' ) @@ -229,9 +230,7 @@ def create_role_permissions( query={'per_page': '350', 'search': f'resource_type="{resource_type}"'} ) if not resource_type_permissions_entities: - raise self._satellite.api.APIResponseError( - f'resource type "{resource_type}" permissions not found' - ) + raise APIResponseError(f'resource type "{resource_type}" permissions not found') permissions_entities = [ entity @@ -243,7 +242,7 @@ def create_role_permissions( permissions_entities_names = {entity.name for entity in permissions_entities} not_found_names = set(permissions_name).difference(permissions_entities_names) if not_found_names: - raise self._satellite.api.APIResponseError( + raise APIResponseError( f'permissions names entities not found "{not_found_names}"' ) self._satellite.api.Filter(