Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retry create-dmg #478

Closed
SanderVocke opened this issue Dec 10, 2024 · 9 comments
Closed

Retry create-dmg #478

SanderVocke opened this issue Dec 10, 2024 · 9 comments

Comments

@SanderVocke
Copy link
Owner

The create-dmg command in build_package/action.yml has a high chance of failure. Wrap it in a retry loop. An example:

# FIXME: Undo this overengineered crap once the following issue gets figured out:
          #        https://github.com/actions/runner-images/issues/7522
          max_tries=10
          i=0
          until create-dmg \
                  --no-internet-enable \
                  --format ULFO \
                  --background ../packaging/macos/dmg-background.png \
                  --hide-extension 'Notes Better.app' \
                  --icon 'Notes Better.app' 180 170 \
                  --icon-size 160 \
                  --text-size 12 \
                  --volname Notes \
                  --volicon ../src/images/notes_icon.icns \
                  --window-size 660 400 \
                  --app-drop-link 480 170 \
                  '${{ steps.vars.outputs.file_name }}' \
                  'Notes Better.app'
          do
              if [ $i -eq $max_tries ]
              then
                  echo 'Error: create-dmg did not succeed even after 10 tries.'
                  exit 1
              fi
              i=$((i+1))
          done
@SanderVocke
Copy link
Owner Author

@openhands-agent please make the described change

Copy link

OpenHands started fixing the issue! You can monitor the progress here.

Copy link

An attempt was made to automatically fix this issue, but it was unsuccessful. A branch named 'openhands-fix-issue-478' has been created with the attempted changes. You can view the branch here. Manual intervention may be required.

SanderVocke pushed a commit that referenced this issue Dec 10, 2024
@SanderVocke
Copy link
Owner Author

@openhands-agent try again. The change should be made to the create-dmg command in the .GitHub/actions/build_package/action.yml GitHub actions script.

Copy link

OpenHands started fixing the issue! You can monitor the progress here.

Copy link

An attempt was made to automatically fix this issue, but it was unsuccessful. A branch named 'openhands-fix-issue-478-try2' has been created with the attempted changes. You can view the branch here. Manual intervention may be required.

SanderVocke pushed a commit that referenced this issue Dec 10, 2024
@SanderVocke
Copy link
Owner Author

@openhands-agent try again.

Specifically, find the create-dmg command in .GitHub/actions/build_package/action.yml, and wrap it in a loop that retries the command until success. Maximum nr of retries should be 10, and the step should fail if it still hasn't succeeded by then.

Copy link

OpenHands started fixing the issue! You can monitor the progress here.

Copy link

An attempt was made to automatically fix this issue, but it was unsuccessful. A branch named 'openhands-fix-issue-478-try3' has been created with the attempted changes. You can view the branch here. Manual intervention may be required.

SanderVocke pushed a commit that referenced this issue Dec 10, 2024
SanderVocke added a commit that referenced this issue Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant