Skip to content
This repository has been archived by the owner on Dec 1, 2020. It is now read-only.

libtuv will fail on unknown error #83

Open
kolipka opened this issue Jul 31, 2017 · 0 comments
Open

libtuv will fail on unknown error #83

kolipka opened this issue Jul 31, 2017 · 0 comments

Comments

@kolipka
Copy link
Contributor

kolipka commented Jul 31, 2017

I am refering to https://github.com/Samsung/libtuv/blob/master/src/uv-common.c#L118

On TizenRT there are some hard to find error definitions. This line cause core dump, while it could return "unknown error" / NULL. Current logic seems to be debug purpose, and end user would not expect exception because there is no proper string defined. It is not easy to get rid of this, and require recompilation/flashing of whole OS.
kolipka pushed a commit to kolipka/libtuv that referenced this issue Aug 7, 2017
Remove assert(0) that breaks IoT.js
29d0372 
On TizenRT there are unknown errors. IoT.js crash instead of returning "Unknown error".
Fix for Samsung#83.

libtuv-DCO-1.0-Signed-off-by: Konrad Lipner [email protected]
@kolipka kolipka mentioned this issue Aug 7, 2017
Merged
yichoi pushed a commit that referenced this issue Aug 10, 2017
@kolipka @yichoi
Remove assert(0) that breaks IoT.js (#84)
b9f8eea 
On TizenRT there are unknown errors. IoT.js crash instead of returning "Unknown error".
Fix for #83.

libtuv-DCO-1.0-Signed-off-by: Konrad Lipner [email protected]
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kolipka