This repository has been archived by the owner on Dec 1, 2020. It is now read-only.
inline declaration removal #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
can you rebase this as #17 is merged? |
akosthekiss
force-pushed
the
inline-fix
branch
from
d4191ab to
f51e01e
Compare
|
Sure, rebased. |
|
@akiss77 , I'm so sorry I didn't see you have already rebased and I made a commit after your rebase. can you please rebase again? |
GCC 5 is more strict about inline semantics: inline declaration without definition emits warning during compilation and will also cause an undefined reference error during linking. Thus, removing the inline specifier from the declarations of uv__time_precise(). libtuv-DCO-1.0-Signed-off-by: Akos Kiss [email protected]
akosthekiss
force-pushed
the
inline-fix
branch
from
f51e01e to
22eebb7
Compare
|
@seanshpark no worries, here it goes :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GCC 5 is more strict about inline semantics: inline declaration without definition emits warning during compilation and will also cause an undefined reference error during linking.
Thus, removing the inline specifier from the declarations of uv__time_precise().
fixes #18
Notes:
inlineare the threeuv_platforms.hs and only for uv__time_precise().