Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Compiler FE] Can remove locomotiv from ARM32 build? #8628

Closed
seanshpark opened this issue Mar 15, 2022 · 6 comments
Closed

[Compiler FE] Can remove locomotiv from ARM32 build? #8628

seanshpark opened this issue Mar 15, 2022 · 6 comments

Comments

@seanshpark
Copy link
Contributor

Investigate if we can remove locomotiv from build for ARM32.

  • locomotiv is used for constant folding pass in logo
  • we may arrange files or introduce logo_xxx module to disconnect dependency
@seanshpark
Copy link
Contributor Author

For #8379

@seanshpark
Copy link
Contributor Author

choice 1) introduce logo-ex for passes that use locomotiv
choice 2) move files in logo to logo-core that are used in luci

I think choice 1 looks better for responsibility

@seanshpark seanshpark mentioned this issue Mar 15, 2022
Closed
@seanshpark
Copy link
Contributor Author

draft code shows that we can unlink locomotiv from ARM32 build.

@seanshpark
Copy link
Contributor Author

CC @llFreetimell

@seanshpark
Copy link
Contributor Author

CC @ejjeong

This was referenced Mar 15, 2022
Merged
Merged
Merged
Merged
Merged
Merged
@seanshpark
Copy link
Contributor Author

done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@seanshpark