Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[infra] CMake duplicate function from FlatBuffers-1.10 and FlatBuffers-1.12 #8397

Closed
seanshpark opened this issue Feb 8, 2022 · 3 comments
Closed

[infra] CMake duplicate function from FlatBuffers-1.10 and FlatBuffers-1.12 #8397

seanshpark opened this issue Feb 8, 2022 · 3 comments
Labels
type/issue There is something strange

Comments

@seanshpark
Copy link
Contributor

In infra/cmake/packages, FlatBuffers-1.10 and FlatBuffers-1.12 both provide FlatBuffers_Generate and FlatBuffers_Target.
FlatBuffers_Target has difference in target_link_libraries(${TGT} PUBLIC flatbuffers-1.10) vs target_link_libraries(${TGT} PUBLIC flatbuffers-1.12) which may give problems.
@seanshpark seanshpark added the type/issue There is something strange label Feb 8, 2022
@seanshpark
Copy link
Contributor Author

This was found while working on #8379.
Upgrading circle schema is needed; but still version mismatch is not good.
Maybe rename FlatBuffers_Target with version like FlatBuffers_1_12_Target ? (this seems a hack)

@seanshpark seanshpark mentioned this issue Feb 22, 2022
Closed
@seanshpark
Copy link
Contributor Author

#8499 may solve this issue

@seanshpark seanshpark mentioned this issue Mar 14, 2022
Closed
@seanshpark
Copy link
Contributor Author

this issue is resolved by using one FB 2.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type/issue There is something strange
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@seanshpark