Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[luci/pass] tizen svace issue on luci/pass #14503

Closed
chunseoklee opened this issue Dec 30, 2024 · 5 comments
Closed

[luci/pass] tizen svace issue on luci/pass #14503

chunseoklee opened this issue Dec 30, 2024 · 5 comments

Comments

@chunseoklee
Copy link
Contributor

chunseoklee commented Dec 30, 2024

if (target_qparam == nullptr)

Tizen static analyzer comments(severity: Major) about the line above :

Warning Message
The pointer returned by operator new can't be null, but it's compared with null at PropagateQParamBackwardPass.cpp 102.

@chunseoklee
Copy link
Contributor Author

@seanshpark We have 2 options :

  1. remove this by patch
  2. keep it as tag "intentional" ( just in case)

Which one do you prefer ?

@seanshpark
Copy link
Contributor

@jinevening PTAL

@jinevening
Copy link
Contributor

The code seems unnecessary. I made a PR to remove it. #14504

@hseok-oh
Copy link
Contributor

hseok-oh commented Jan 2, 2025

FYI. Several similar issues are in luci/service, but they were marked as ignored as intentional.

ex. compiler/luci/service/src/Nodes/CircleUnpackOut.cpp

  auto *cloned = _graph->nodes()->create<luci::CircleUnpackOut>();
  if (cloned != nullptr)
    cloned->index(node->index());

@seanshpark
Copy link
Contributor

fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants