Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[onecc-docker] Fix onecc-docker fails due to downloading from onert release #11539

Closed
profornnan opened this issue Sep 15, 2023 · 0 comments
Closed

Comments

@profornnan
Copy link
Contributor

WHAT

Change to use the latest version that included one-compiler deb in assets

WHY

When the latest release is onert release, onecc-docker fails to download the one-compiler.

Therefore, there is an issue with cfg compilation using onecc-docker.

def _request_recent_version(token=None):
response = RequestHandler(
token,
timeout=5).make_request(url="https://api.github.com/repos/Samsung/ONE/releases")
versions = [release_item["tag_name"] for release_item in response.json()]
for version in versions:
# Return the latest version with the given format
# to filter out such as 'onert-micro-0.1.0' release
# which doesn't contain onecc package.
if bool(re.match(r'^\d+\.\d+\.\d+$', version)):
return version
raise SystemExit('[onecc-docker] Failed to get latest onecc version')

_request_recent_version is implemented to return the most recently deployed version.

https://api.github.com/repos/Samsung/ONE/releases

Using regular expressions, it searches for tag_name in the release data that contains only major, minor, and patch components.

The issue arises because the current latest version, 1.25.0, is a release for ONE Runtime, and ONE Compiler is not included in the assets.

HOW

I plan to iterate through tag names starting from the latest version and check if the assets list contains one-compiler-bionic_${VERSION}_amd64.deb in the name. If found, _request_recent_version will returns that version.

Related Issues

#10811
Samsung/ONE-vscode#1604

@profornnan profornnan changed the title [onecc-docker] Change to use the latest version that included one-compiler deb [onecc-docker] Fix onecc-docker fails due to downloading from onert release Sep 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant