-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Managing SAM scores #1566
Comments
@lemmaa , these are imported codes from netron. what is your recommendation for these? |
@lemmaa please share how to read these lines
|
@lemmaa , there are lots of |
I don't think it's appropriate from a maintenance point of view that we directly modify the code of external modules. In this case, you will have to process it as exclude in the analysis target. However, if you plan to disconnect from an external module, it would be appropriate to modify the source code and resolve the issues. |
Basically the same as #1566 (comment) . |
Thanks for your recommendation! My initial direction was/is to maintain with the upstream, so it would be better to exclude this folder. |
Let's track this issue. https://github.sec.samsung.net/RS7-Architectural-Refactoring/SAM-Tools/issues/2566 |
CC (total 681)
|
CC violation / filecircle_schema_generated.ts is ignored from the SAM analysis (#1640, by @hseok-oh)
|
SAM Score, typescript, 2023-09-15 (main branch, cad87ff)https://analysishub.sec.samsung.net/service/analyses/2373959 Thanks to @hseok-oh |
Javascript SAM Score, 2023-09-15 (main branch, cad87ff)
|
We need a review and resolution of issues related to SAM scores. Please refer to the CC report of the analysis results.
/cc @Samsung/one-vscode
(Added by dayo09)
Analysis target ID : 10490
Analysis policy: typescript.mandatory.sr
The text was updated successfully, but these errors were encountered: