Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CircleEditor] Refactoring structure and codes #1455

Open
15 tasks
llFreetimell opened this issue Nov 9, 2022 · 1 comment
Open
15 tasks

[CircleEditor] Refactoring structure and codes #1455

llFreetimell opened this issue Nov 9, 2022 · 1 comment
Assignees
Labels
Project/Task Working Item

Comments

@llFreetimell
Copy link
Contributor

llFreetimell commented Nov 9, 2022

What?

Let's refactor overall structure and source codes for CircleEditor.

Why?

  • To improve performance
  • To improve static analysis score
  • To improve readability and maintainability
    • Remove source codes which are not related with editing circle file
    • Rename variable and functions
  • To fix bugs

Draft


TODO Items

  • Minimize duplicated source codes
    • Reposition external source codes
    • Remove not modified source codes from our own codes
  • Remove source codes which are not related with editing circle file
  • Rename variable and functions which have unclear names
  • Improve performance
    • Substitute opening a file with rendering graph after editing
    • Do not change when before and after are same
  • Clean codes
    • Separate value validation function when save
  • Fix bugs
    • Edit custom attribute --> Ctrl+z --> arrows are dismissed
    • BCQ(maybe some other operations too) attribute types are null
    • Custom options only supports few types
    • Even invalid attribute values are given, changes are generated
@llFreetimell
Copy link
Contributor Author

llFreetimell commented Nov 9, 2022

Feature Requests

  • When duplicated keys for custom option are given, alert
  • Represent shape_signature

@YuyeonHan YuyeonHan pinned this issue Dec 8, 2022
@llFreetimell llFreetimell unpinned this issue Jan 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Project/Task Working Item
Projects
None yet
Development

No branches or pull requests

1 participant