Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Full test suite #6

Open
Samasaur1 opened this issue Sep 1, 2018 · 4 comments
Open

Full test suite #6

Samasaur1 opened this issue Sep 1, 2018 · 4 comments
Labels
enhancement New feature or request good first issue Good for newcomers
Milestone
Version 1.0.0

Comments

@Samasaur1
Copy link
Owner

Obviously, DiceKit should have complete tests using the Swift Package Manager and XCTest
@Samasaur1 Samasaur1 added enhancement New feature or request good first issue Good for newcomers labels Sep 1, 2018
@Samasaur1 Samasaur1 added this to the Version 1.0.0 milestone Sep 1, 2018
@Samasaur1
Copy link
Owner Author

There are 6 more tests that need to be implemented:

  • WeightedDieTests.testDoubleAverageResultProperty
  • WeightedDieTests.testAverageResultProperty
  • WeightedDieTests.testRollingMultipleTimes
  • DiceTests.testRolling
  • DiceTests.testRollingMultipleTimes
  • DiceTests.testChanceInRange

Notice that 5/6 of them should have been written before this version, because they don't test new features

Originally posted by @Samasaur1 in #62 (comment)

@Samasaur1
Copy link
Owner Author

a4a62f6 has now implemented the last test introduced in #62, which means that there are only 5 more tests to implement:

  • WeightedDieTests.testDoubleAverageResultProperty
  • WeightedDieTests.testAverageResultProperty
  • WeightedDieTests.testRollingMultipleTimes
  • DiceTests.testRolling
  • DiceTests.testRollingMultipleTimes

@Samasaur1
Copy link
Owner Author

Additionally, ever since v0.18.0 (#66), everything is a struct, so all the .copy() and init(copyOf:) calls are deprecated and redundant.

@Samasaur1
Copy link
Owner Author

This is even more important if we want to catch bugs like #88 — we should test all the functions implemented in the extensions to Rollable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
Version 1.0.0
Development

No branches or pull requests
1 participant
@Samasaur1