Danger should not tell PR authors to put changes in the Upcoming section of the changelog if it is a new version PR #105
Labels
enhancement
New feature or request
internal change
Something that only changes on the inside
low priority
Something that is not urgent
When making a PR to master that is not a new version, if the author has not yet updated the CHANGELOG, Danger will tell them to "Put your changes in the UPCOMING section". This is what we want. However, this same message is outputted even if the PR is for a new version (in which case everything in the UPCOMING section, along with any new information, should be under a version heading).
Here's the part of the Dangerfile that controls this output:
DiceKit/Dangerfile.swift
Lines 92 to 101 in b91141b
We should put these CHANGELOG checks inside the
if-else
statement checking new versions, in order to give more useful output.The text was updated successfully, but these errors were encountered: