Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

react-map-gl 7 support #132

Open
dannyskoog opened this issue Feb 8, 2022 · 7 comments
Open

react-map-gl 7 support #132

dannyskoog opened this issue Feb 8, 2022 · 7 comments

Comments

@dannyskoog
Copy link

dannyskoog commented Feb 8, 2022

I'm currently int the process of updating react-map-gl to version 7 but get compilation errors (originating from react-map-gl-geocoder) saying:

Attempted import error: 'FlyToInterpolator' is not exported from 'react-map-gl' (imported as 'r').

And FlyToInterpolator seems to have been removed (https://visgl.github.io/react-map-gl/docs/upgrade-guide#upgrading-to-v70). Are there any plans of supporting version 7?

@SamSamskies
Copy link
Owner

Sorry, no plans. It's possible that I'll do it at some point, but it probably won't be anytime soon. I usually suggest people just copy pasta the code and modify it for their needs especially since I don't really work on this project anymore. https://github.com/SamSamskies/react-map-gl-geocoder/blob/master/src/index.js

@dannyskoog
Copy link
Author

I understand. Well, thanks for the quick and informative answer. Appreciate it!

@FrancescoBurchielli
Copy link

hi everyone, what is the solution here? Does downgrading just react-map-gl help or do I need to downgrade both react-map-gl and react-map-gl-geocoder? Many thanks much appreciated!

@bhison
Copy link

bhison commented Jun 8, 2022

hi everyone, what is the solution here? Does downgrading just react-map-gl help or do I need to downgrade both react-map-gl and react-map-gl-geocoder? Many thanks much appreciated!

just React-Map-GL

@joelugh
Copy link

joelugh commented Jun 12, 2022

Haven't tried it yet myself, but just noticed that the release notes say that you don't need a react wrapper for geocoder any more.

https://visgl.github.io/react-map-gl/docs/whats-new#react-map-gl-v70

Compatibility: first and third-party plugins! Directly use mapbox-gl-draw, mapbox-gl-geocoder, to name a few.

@bhison
Copy link

bhison commented Jun 13, 2022

good advice @joelugh

Another option is to recreate the react-map-gl v7 geocoder example

@stephenavocado
Copy link

Haven't tried it yet myself, but just noticed that the release notes say that you don't need a react wrapper for geocoder any more.

https://visgl.github.io/react-map-gl/docs/whats-new#react-map-gl-v70

Compatibility: first and third-party plugins! Directly use mapbox-gl-draw, mapbox-gl-geocoder, to name a few.

Hey @joelugh, did you end up trying this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants