-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Margin left spacing in Switch component with reverse = true prop, the label text wasn't centered #7179
Comments
@ljemmo @harpalsingh regarding the ON/OFF labels, can you advise as to whether this is something we want to consider, please? |
FE-7066 |
This feature request has been moved to a separate issue: #7185 |
Can you confirm what you mean by 'on off labels'? This issue seems to be about margin placement? |
@ljemmo see the link provided by James above for clarification 😄 |
@damienrobson-sage so i understand that he's wanting the margin bug to be fixed when the reverse prop is set to true (BTW DS no longer support this layout so wouldn't advise this usage where possible). However, i don't understand the comment about On / Off labels. I missed @Parsium 's comment so will review the data there. |
the margins have been updated to take into account reverse, labelInline and margin props fixes: #7179
the margins have been updated to take into account reverse, labelInline and margin props fixes: #7179
the margins have been updated to take into account reverse, labelInline and margin props fixes: #7179
the margins have been updated to take into account reverse, labelInline and margin props fixes: #7179
the margins have been updated to take into account reverse, labelInline and margin props fixes: #7179
the margins have been updated to take into account reverse, labelInline and margin props fixes: #7179
Description
I'm using the Switch component with the reverse prop activated the margin left spacing has 24px, if I use ml="0" then it continue with this margin.
Reproduction
https://stackblitz.com/edit/parsium-carbon-starter-peqjdaze?file=src%2FApp.tsx
Steps to reproduce
No response
JIRA ticket numbers (Sage only)
No response
Suggested solution
No response
Carbon version
146.5.3
Design tokens version
No response
Relevant browsers
Chrome
Relevant OSs
MacOS
Additional context
No response
Confidentiality
The text was updated successfully, but these errors were encountered: