Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-indent C code #187

Closed
JanWielemaker opened this issue Dec 13, 2016 · 1 comment
Closed

Re-indent C code #187

JanWielemaker opened this issue Dec 13, 2016 · 1 comment

Comments

@JanWielemaker
Copy link
Member

Current style is from Anjo Anjewierden, the guru who teached me to program in C. I don't think it is a bad style, but it is not supported by modern tools. Considering that quite some attention has been paid to have a consistent layout where values are often nicely displayed as tables, a general reformat is (I think) undesirable.

What about this?

  • Keep indentiation increment of 2 (otherwise all will break)
  • Re-format to
     if ( .... ) {
       body
     } else {
      ...
     }
    
@JanWielemaker JanWielemaker added this to the 7.4.0 milestone Dec 13, 2016
@JanWielemaker
Copy link
Member Author

After discussion with notably Keri Harris, it was decided not to change the indentation. We do not expect much gain while the effort is considerable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant