Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Add input for uploading banner #48

Closed
AshutoshDash1999 opened this issue May 14, 2024 · 5 comments
Closed

Feat: Add input for uploading banner #48

AshutoshDash1999 opened this issue May 14, 2024 · 5 comments
Assignees
Labels
enhancement New feature or request gssoc GSSOC 2024 level2 25 points priority : high GSSOC 2024

Comments

@AshutoshDash1999
Copy link
Contributor

Is your feature request related to a problem? Please describe.
The banner is static for now and hence can't be changed with new image.

Describe the solution you'd like
When someone will click on the existing banner a window will open to choose a file and select that banner.

Additional context

  • The upload button will shifted to bottom right and on top of banner.
  • The max file size will be 2MB and minimum dimension should be 1600 x 400

Please assign this issue to me under GSSOC 24.

@SUGAM-ARORA
Copy link
Owner

@AshutoshDash1999 Issue has been assigned to you

@SUGAM-ARORA SUGAM-ARORA added enhancement New feature or request gssoc GSSOC 2024 level2 25 points priority : high GSSOC 2024 labels May 14, 2024
@AshutoshDash1999
Copy link
Contributor Author

hi @SUGAM-ARORA I think this should be level 3 as I am adding completely new feature and not just improving existing ones.

@AshutoshDash1999
Copy link
Contributor Author

@SUGAM-ARORA please review this PR: #67

@SUGAM-ARORA
Copy link
Owner

@AshutoshDash1999 I assigned it as level 2 based on its complexity and time consumption

@SUGAM-ARORA
Copy link
Owner

@SUGAM-ARORA please review this PR: #67

Successfully merged it. Great work

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request gssoc GSSOC 2024 level2 25 points priority : high GSSOC 2024
Projects
None yet
Development

No branches or pull requests

2 participants