Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

USB composite CustomHID endpoint size configuration problem #300

Open
LaurentGolay opened this issue Nov 19, 2024 · 2 comments
Open

USB composite CustomHID endpoint size configuration problem #300

LaurentGolay opened this issue Nov 19, 2024 · 2 comments
Assignees
Labels
bug Something isn't working internal bug tracker Issue confirmed and logged into the internal bug tracking system mw Middleware-related issue or pull-request. st usb STMicroelectronics' Universal Serial Bus (Host or Device) library usb Universal Serial Bus

Comments

@LaurentGolay
Copy link

LaurentGolay commented Nov 19, 2024

Brief description
USB composite CustomHID wrongly refers endpoint size definitons and mismatch IN and OUT endpoints configuration.

Describe the set-up
The board: (not relevant) custom board with STM32H7B0IBT6 MCU
IDE: (not relevant) STM32CubeIDE 1.16.1, GNU Tools for STM32 11.3rel1.

Describe the bug
USBD_CMPSIT_CUSTOMHIDDesc() in usbd_composite_builder.c uses wrong definition for Out Endpoint size configuration. It uses "CUSTOM_HID_EPIN_SIZE" instead of "CUSTOM_HID_EPOUT_SIZE", which will causes issues if sizes are different.
Similarly, SBD_CMPSIT_AddToConfDesc() function, in CLASS_TYPE_CHID case, refers to CUSTOM_HID_EPOUT_SIZE for both endpoint setting (with USBD_CMPSIT_AssignEp).

How To Reproduce
Configure a composite USB Device that includes a CustomHID interface.
Set different sizes for IN and OUT endpoints.

@ALABSTM ALABSTM self-assigned this Nov 20, 2024
@ALABSTM ALABSTM added bug Something isn't working usb Universal Serial Bus st usb STMicroelectronics' Universal Serial Bus (Host or Device) library labels Nov 20, 2024
@ALABSTM ALABSTM added the mw Middleware-related issue or pull-request. label Nov 20, 2024
@ALABSTM ALABSTM moved this from To do to Analyzed in stm32cube-mcu-mw-dashboard Nov 21, 2024
@ALABSTM
Copy link
Contributor

ALABSTM commented Nov 21, 2024

Hi @LaurentGolay,

Your point looks relevant. It has been forwarded to our development teams. Let's wait for their feedback.

With regards,

@ALABSTM
Copy link
Contributor

ALABSTM commented Nov 21, 2024

ST Internal Reference: 196750

@ALABSTM ALABSTM added the internal bug tracker Issue confirmed and logged into the internal bug tracking system label Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working internal bug tracker Issue confirmed and logged into the internal bug tracking system mw Middleware-related issue or pull-request. st usb STMicroelectronics' Universal Serial Bus (Host or Device) library usb Universal Serial Bus
Projects
Development

No branches or pull requests

2 participants