Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add "blank" music discs that can be burned with pv-addon-discs #73

Open
ProjectHSI opened this issue Apr 6, 2024 · 8 comments
Open
Labels
priority: low This issue only describes a minor inconvenience. type: feature New feature or request

Comments

@ProjectHSI
Copy link
Collaborator

ProjectHSI commented Apr 6, 2024

basically a more achievable way of getting music discs to burn without too much effort. maybe something like they spawn in villages or can be craftable. the music discs by themselves can't be played but can be burned and then played with pv-addon-discs

@ProjectHSI
Copy link
Collaborator Author

@ProjectHSI
Copy link
Collaborator Author

ProjectHSI commented Apr 6, 2024

@ProjectHSI ProjectHSI closed this as not planned Won't fix, can't repro, duplicate, stale Apr 7, 2024
@ProjectHSI ProjectHSI reopened this Apr 7, 2024
@nomadjimbob nomadjimbob added type: feature New feature or request priority: low This issue only describes a minor inconvenience. labels Apr 7, 2024
@nomadjimbob
Copy link
Member

The idea of 'survival towns' is to have vendors (including the spawn town). We could have a vendor sell these blank discs and a second vendor which requests a url to burn onto the disc through chat?

@ProjectHSI
Copy link
Collaborator Author

2nd vendor idea sounds neat. Are you saying the 2nd vendor replaces the command or supplements it with an abstraction?

@nomadjimbob
Copy link
Member

Replaces the command (runs the command on behalf of the player, or the plugin does what it needs to do to make it work). Mods would have the command to override if needed.

I started a SMShopKeeper Citizens trait in the 1.5 plugin but will prob be a 1.6 addition

@ProjectHSI
Copy link
Collaborator Author

ProjectHSI commented Apr 8, 2024

Alright. I think we should have the command available for non-survival worlds (creative plots specifically)

@nomadjimbob
Copy link
Member

Yep. We can enable it the command like we do with worldedit with gamemode=creative. Allows testing in the creative world, and mods to explicitly have to change gamemodes in survival worlds to use the command

@ProjectHSI
Copy link
Collaborator Author

ProjectHSI commented Apr 10, 2024

Cost:
Bronze to buy a blank disc and erase a disc
Iron to burn a blank disc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: low This issue only describes a minor inconvenience. type: feature New feature or request
Development

No branches or pull requests

2 participants