Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♻️ 🔒 Don't allow non-secure URLs #1100

Open
4 tasks done
matt-goldman-ssw opened this issue Oct 17, 2024 · 0 comments · May be fixed by #1102
Open
4 tasks done

♻️ 🔒 Don't allow non-secure URLs #1100

matt-goldman-ssw opened this issue Oct 17, 2024 · 0 comments · May be fixed by #1102
Assignees

Comments

@matt-goldman-ssw
Copy link
Contributor

matt-goldman-ssw commented Oct 17, 2024

Cc:

Hi @zacharykeeping

Pain

During the Sprint Review you should me a PR (which I approved #1078) which allows people to save either an http:// url or https:///

We should not allow http URLs in the app - don't forget we are making these available for people to open from others' profiles.

What code could be improved?

Check the URL before saving for http://, and if we find it, replace it with https://. This can be done in the API without redeploying the app and doesn't break the current validation.

FAQ

  • What if someone's site doesn't support https and it breaks the link?
    • Good.

Tasks

  • Update the command that saves the URLs
  • Ensure the UI is updated with the corrected URL on callback

Acceptance Criteria

More Information

Screenshots

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants