You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
During the Sprint Review you should me a PR (which I approved #1078) which allows people to save either an http:// url or https:///
We should not allow http URLs in the app - don't forget we are making these available for people to open from others' profiles.
What code could be improved?
Check the URL before saving for http://, and if we find it, replace it with https://. This can be done in the API without redeploying the app and doesn't break the current validation.
FAQ
What if someone's site doesn't support https and it breaks the link?
Good.
Tasks
Update the command that saves the URLs
Ensure the UI is updated with the corrected URL on callback
Cc:
Hi @zacharykeeping
Pain
During the Sprint Review you should me a PR (which I approved #1078) which allows people to save either an
http://
url orhttps://
/We should not allow
http
URLs in the app - don't forget we are making these available for people to open from others' profiles.What code could be improved?
Check the URL before saving for
http://
, and if we find it, replace it withhttps://
. This can be done in the API without redeploying the app and doesn't break the current validation.FAQ
https
and it breaks the link?Tasks
Acceptance Criteria
More Information
Screenshots
Thanks!
The text was updated successfully, but these errors were encountered: