Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feat/#36] Toast component #37

Merged
merged 80 commits into from
Jan 15, 2025
Merged

[Feat/#36] Toast component #37

merged 80 commits into from
Jan 15, 2025

Conversation

minjeoong
Copy link
Collaborator

@minjeoong minjeoong commented Jan 13, 2025

πŸ”₯ Related Issues

βœ… μž‘μ—… 리슀트

  • Toast μ»΄ν¬λ„ŒνŠΈ κ΅¬ν˜„

πŸ”§ μž‘μ—… λ‚΄μš©

스크란샷 2025-01-14 05 47 40 ν† μŠ€νŠΈ props 확인해주십쇼 ν•΄λ‹Ή μ»΄ν¬λ„ŒνŠΈλŠ” 5초 뒀에 사라지도둝 κ΅¬ν˜„ν•˜μ˜€μŠ΅λ‹ˆλ‹€.

[ @param variant μ’…λ₯˜ (default, error) ]
Toast λŠ” variant κ°€ λ‘κ°œ μž…λ‹ˆλ‹€.

  1. variant = default
  2. variant = error

[ @param iconColor μ•„μ΄μ½˜ 색상 (black, white) ]
μ˜†μ— μžˆλŠ” X λ²„νŠΌμ˜ 색상은 props 둜 μ€˜μ•Ό ν•©λ‹ˆλ‹€.
μΆ”ν›„ λ””μžμΈμ— 따라 같은 배경이라도 λ²„νŠΌ 색깔이 λ‹€λ₯Ό 수 μžˆμ„ 것이라 μƒκ°ν•˜μ—¬ λ‹€μŒκ³Ό 같이 κ΅¬ν˜„ν–ˆλŠ”λ°, ν˜Ήμ‹œ λ‹€λ₯Έ 의견 μžˆμœΌμ‹œλ©΄ μ£Όμ‹œλ©΄ κ°μ‚¬ν•©λ‹ˆλ‹€.

πŸ“£ λ¦¬λ·°μ–΄μ—κ²Œ μ–΄λ– μ‹ κ°€μš”?

ν•΄λ‹Ή λ””μžμΈ λ°°κ²½ κ΅¬ν˜„ 문제 μžˆμ—ˆμŠ΅λ‹ˆλ‹€.

  1. μ™Όμͺ½μ— λΉ¨κ°„ μš”μ†Œλ₯Ό 직접 λ Œλ”λ§ ν•˜λŠ” 방법
  2. 배경을 μΆ”μΆœν•΄μ„œ μš”μ†Œμ˜ λ°±κ·ΈλΌμš΄λ“œ ν•˜λŠ” 방법

두 방법 쀑 2번 방법 μ„ νƒν•˜μ˜€μŠ΅λ‹ˆλ‹€.
κ·Έ λ°©λ²•μ—μ„œ μ˜€λŠ” λ¬Έμ œλŠ”
-> μΆ”μΆœν•œ μš”μ†Œμ˜ 크기보닀 ν† μŠ€νŠΈ 크기가 컀지면 λ¬Έμ œκ°€ μžˆμ„ 수 있음.

ν•΄λ‹Ή μš”μ†Œμ˜ 크기 자체λ₯Ό κ³ μ •ν•˜λŠ” λ°©λ²•μœΌλ‘œ ν•΄κ²°ν•˜μ˜€μŠ΅λ‹ˆλ‹€.

πŸ“Έ μŠ€ν¬λ¦°μƒ· / GIF / Link

  1. variant = default
    https://github.com/user-attachments/assets/d6074f45-73a0-40b9-803a-f3906bac3456

  2. variant = error
    https://github.com/user-attachments/assets/15685dae-0225-457e-b670-c0bb653212ab

Leeyoonji23 and others added 30 commits January 12, 2025 04:47
…entComponent

# Conflicts:
#	src/page/main/index/Main.tsx
minjeoong and others added 21 commits January 14, 2025 16:08
…mponent

# Conflicts:
#	src/asset/svg/index.ts
#	src/page/main/index/Main.tsx
[Feat] Contents μ»΄ν¬λ„ŒνŠΈ κ΅¬ν˜„
[Feat] ν”Œλ‘œνŒ… λ²„νŠΌ μ»΄ν¬λ„ŒνŠΈ
[Feat] ν•˜λ‹¨ Nav μ»΄ν¬λ„ŒνŠΈ κ΅¬ν˜„
[Feat/#26 ] λŒ“κΈ€ μ»΄ν¬λ„ŒνŠΈ κ΅¬ν˜„
@minjeoong minjeoong changed the title [Feat] Toast component [Feat/#36] Toast component Jan 14, 2025
Copy link
Collaborator

@ocahs9 ocahs9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ν† μŠ€νŠΈ μ»΄ν¬λ„ŒνŠΈ κΉ”λ”ν•˜κ²Œ κ΅¬ν˜„λ˜μ—ˆλ„€μš”~

λ‹€λ§Œ λ‹Ήμž₯은 μ‚¬μš©ν•˜λŠ” 곳이 μ—†μ§€λ§Œ λ‚˜μ€‘μ— μ‚¬μš©ν•˜κ²Œ λœλ‹€λ©΄ prop이 더 ν•„μš”ν•  κ±° κ°™μ•„μš”!
isVisible 둜 ν† μŠ€νŠΈ μ˜€ν”ˆ μ—¬λΆ€λ₯Ό κ΄€λ¦¬ν•˜κ³ , useToast와 같은 훅을 톡해 ν† μŠ€νŠΈ μƒνƒœλ₯Ό κ΄€λ¦¬ν•˜λŠ” 게 μ‚¬μš©μ„± μΈ‘λ©΄μ—μ„œ 쒋을 것 κ°™μ•„μš”! 참고만 해두고 λ‚˜μ€‘μ— μ—¬μœ λ˜κ±°λ‚˜ μ‹€μ œλ‘œ μ‚¬μš©ν•  λ•Œ κ°œμ„ ν•΄λ΄…μ‹œλ‹€!

좩돌 μ²˜λ¦¬λŠ” μ œκ°€ 방금 ν•˜κ³  push ν•΄λ’€μŠ΅λ‹ˆλ‹€ μ–΄ν‘Έν• κ²Œμš”!

@minjeoong minjeoong merged commit 0f68118 into develop Jan 15, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ feat κΈ°λŠ₯ κ΅¬ν˜„ πŸ’„ style κΈ°λŠ₯에 영ν–₯을 주지 μ•ŠλŠ” 컀밋, μ½”λ“œ μˆœμ„œ, cssλ“±μ˜ 포맷에 κ΄€ν•œ 컀밋
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ Feat ] Toast μ»΄ν¬λ„ŒνŠΈ κ΅¬ν˜„
4 participants