Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

catchall route hard to debug #19

Open
nathanallen opened this issue Feb 24, 2017 · 1 comment · May be fixed by #20
Open

catchall route hard to debug #19

nathanallen opened this issue Feb 24, 2017 · 1 comment · May be fixed by #20
Labels
commonly-seen-error

Comments

@nathanallen
Copy link
Contributor

nathanallen commented Feb 24, 2017 •
edited
Loading

Lots of confusing bugs emerge due to the catchall/wildcard/splat route serving HTML. The most common example is /wrong/path/to/some.js raising "SyntaxError: unexpected token <" in the client.

Recommendation:

  • limit catchall to only known route patterns (e.g. /albums, /albums/:id, /albums/:id/songs, etc).
  • but add a final catchall that responds with a status 404.
@mnfmnfm
Copy link

mnfmnfm commented Feb 24, 2017 •
edited by nathanallen
Loading

Specifically, nathan's suggested code is:

app.get([
  '/albums',
  '/albums/:albumId',
  '/albums/:albumId/songs',
  '/albums/:albumId/songs/:songId'
], function homepage (req, res) {
  res.sendFile(__dirname + '/views/index.html');
});

app.get("*", function notFound(req, res){
  res.sendStatus(404);
})

@nathanallen nathanallen linked a pull request Feb 24, 2017 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
commonly-seen-error
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

restrict catchall html endpoint, add 404 SF-WDI-LABS/tunely-angular
2 participants
@nathanallen @mnfmnfm