From 5845997053e26ca22ea82a72220aa8b2a017f9b7 Mon Sep 17 00:00:00 2001 From: Nayden Naydenov <31909318+nnaydenow@users.noreply.github.com> Date: Wed, 5 Feb 2025 17:52:05 +0200 Subject: [PATCH] chore: clear wait command in tests (#10774) Remove unnecessary waits in Cypress tests. --- .../cypress/specs/ViewSettingsDialog.cy.tsx | 6 --- packages/main/cypress/specs/Input.cy.tsx | 48 ------------------- 2 files changed, 54 deletions(-) diff --git a/packages/fiori/cypress/specs/ViewSettingsDialog.cy.tsx b/packages/fiori/cypress/specs/ViewSettingsDialog.cy.tsx index 3523de294d29..024b0018d927 100644 --- a/packages/fiori/cypress/specs/ViewSettingsDialog.cy.tsx +++ b/packages/fiori/cypress/specs/ViewSettingsDialog.cy.tsx @@ -12,9 +12,6 @@ describe("View settings dialog - selection", () => { ); - // eslint-disable-next-line cypress/no-unnecessary-waiting - cy.wait(100); // Wait after mounting the component temporarily, until the component is fully rendered TODO: remove this after the issue is fixed - // Open the dialog and wait until it's visible cy.get("[ui5-view-settings-dialog]") .as("vsd") @@ -105,9 +102,6 @@ describe("View settings dialog - selection", () => { ); - // eslint-disable-next-line cypress/no-unnecessary-waiting - cy.wait(100); // Wait after mounting the component temporarily, until the component is fully rendered TODO: remove this after the issue is fixed - // Open the dialog and wait until it's visible cy.get("[ui5-view-settings-dialog]") .as("vsd") diff --git a/packages/main/cypress/specs/Input.cy.tsx b/packages/main/cypress/specs/Input.cy.tsx index b72e4ccf48b1..a4b0359d6ac0 100644 --- a/packages/main/cypress/specs/Input.cy.tsx +++ b/packages/main/cypress/specs/Input.cy.tsx @@ -149,29 +149,21 @@ describe("Input general interaction", () => { cy.get("@input") .realClick(); - // eslint-disable-next-line cypress/no-unnecessary-waiting - cy.wait(200); cy.get("@input") .realType("C"); - // eslint-disable-next-line cypress/no-unnecessary-waiting - cy.wait(200); cy.get("@popover") .should("have.attr", "open"); cy.get("@input") .realPress("ArrowDown"); - // eslint-disable-next-line cypress/no-unnecessary-waiting - cy.wait(200); cy.get("@input") .should("have.attr", "value", "Titanium"); cy.get("@input") .realPress("Escape"); - // eslint-disable-next-line cypress/no-unnecessary-waiting - cy.wait(200); cy.get("@input") .should("have.value", "C"); @@ -198,21 +190,15 @@ describe("Input general interaction", () => { cy.get("@input") .realClick(); - // eslint-disable-next-line cypress/no-unnecessary-waiting - cy.wait(200); cy.get("@input") .realType("c"); - // eslint-disable-next-line cypress/no-unnecessary-waiting - cy.wait(200); cy.get("@popover") .should("have.attr", "open"); cy.get("@input") .realPress("ArrowDown"); - // eslint-disable-next-line cypress/no-unnecessary-waiting - cy.wait(200); cy.get("@input") .should("have.value", "Compact") @@ -224,8 +210,6 @@ describe("Input general interaction", () => { cy.get("@input") .realPress("ArrowDown"); - // eslint-disable-next-line cypress/no-unnecessary-waiting - cy.wait(200); cy.get("ui5-suggestion-item") .eq(2) @@ -304,18 +288,12 @@ describe("Input arrow navigation", () => { .as("popover"); cy.get("@input").realClick(); - // eslint-disable-next-line cypress/no-unnecessary-waiting - cy.wait(200); cy.get("@input").realType("c"); - // eslint-disable-next-line cypress/no-unnecessary-waiting - cy.wait(200); cy.get("@popover") .should("have.attr", "open"); cy.get("@input").realPress("ArrowDown"); - // eslint-disable-next-line cypress/no-unnecessary-waiting - cy.wait(200); cy.get("ui5-suggestion-item").eq(1).should("have.attr", "text", "Compact"); cy.get("@input").should("not.have.attr", "focused"); @@ -323,26 +301,18 @@ describe("Input arrow navigation", () => { cy.get("@input") .realPress("ArrowDown"); - // eslint-disable-next-line cypress/no-unnecessary-waiting - cy.wait(200); cy.get("ui5-suggestion-item").eq(2).should("have.attr", "focused"); cy.get("ui5-suggestion-item").eq(1).should("not.have.attr", "focused"); cy.get("@input") .realPress("ArrowUp"); - // eslint-disable-next-line cypress/no-unnecessary-waiting - cy.wait(200); cy.get("ui5-suggestion-item").eq(1).should("have.attr", "focused"); cy.get("ui5-suggestion-item").eq(2).should("not.have.attr", "focused"); cy.get("@input").realPress("ArrowUp"); - // eslint-disable-next-line cypress/no-unnecessary-waiting - cy.wait(200); cy.get("@input").realPress("ArrowUp"); - // eslint-disable-next-line cypress/no-unnecessary-waiting - cy.wait(200); cy.get("@input").should("have.attr", "focused"); cy.get("ui5-suggestion-item").first().should("not.have.attr", "focused"); @@ -376,23 +346,15 @@ describe("Input PAGEUP/PAGEDOWN navigation", () => { cy.get("@input") .realClick(); - // eslint-disable-next-line cypress/no-unnecessary-waiting - cy.wait(200); cy.get("@input") .realType("a"); - // eslint-disable-next-line cypress/no-unnecessary-waiting - cy.wait(200); cy.get("@input") .realPress("ArrowDown"); - // eslint-disable-next-line cypress/no-unnecessary-waiting - cy.wait(200); cy.get("@input") .realPress("PageDown"); - // eslint-disable-next-line cypress/no-unnecessary-waiting - cy.wait(200); cy.get("ui5-suggestion-item") .eq(11) @@ -409,18 +371,12 @@ describe("Input PAGEUP/PAGEDOWN navigation", () => { cy.get("@input") .realClick(); - // eslint-disable-next-line cypress/no-unnecessary-waiting - cy.wait(200); cy.get("@input") .realType("a"); - // eslint-disable-next-line cypress/no-unnecessary-waiting - cy.wait(200); cy.get("@input") .realPress("ArrowUp"); - // eslint-disable-next-line cypress/no-unnecessary-waiting - cy.wait(200); cy.get("ui5-suggestion-item-group") .eq(0) @@ -428,13 +384,9 @@ describe("Input PAGEUP/PAGEDOWN navigation", () => { cy.get("@input") .realPress("PageDown"); - // eslint-disable-next-line cypress/no-unnecessary-waiting - cy.wait(200); cy.get("@input") .realPress("PageUp"); - // eslint-disable-next-line cypress/no-unnecessary-waiting - cy.wait(200); cy.get("ui5-suggestion-item-group") .eq(0)