Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Combobox, MultiCombobox]: No FormControl support #91

Closed
1 of 4 tasks
ilhan007 opened this issue Nov 1, 2023 · 5 comments
Closed
1 of 4 tasks

[Combobox, MultiCombobox]: No FormControl support #91

ilhan007 opened this issue Nov 1, 2023 · 5 comments
Assignees
Labels
Angular generator Topic related to the Angular Generator SAP Build Process Automation
Milestone

Comments

@ilhan007
Copy link
Member

ilhan007 commented Nov 1, 2023

Created the issue on behalf of SAP Build Process Automation:
Combobox, MultiCombobox - FormControl support is missing.

Expected Behavior

Steps to Reproduce

  1. Go to '...'
  2. ...
  3. ...

Isolated Example

Context

  • UI5 Web Components version: {...}
  • UI5 Web Components for Angular version: {...}
  • Angular Version: {...}
  • OS/Platform: {...}
  • Browser: {...}
  • Affected component: {...}

Log Output / Stack Trace / Screenshots

{...}

Priority

  • Low
  • Medium
  • High
  • Very High

The priority indicates the severity of the issue. To set the appropriate priority consider the following criteria:

  • Breaks entire application or system - High or Very High
  • Accessibility issue - Medium or High
  • Functional issue - Medium or High
  • Visual issue - Low or Medium

Note: The priority might be re-evaluated by the issue processor.

Stakeholder Info (if applicable)

  • Organization: {...}
  • Business impact: {...}
Copy link

github-actions bot commented Nov 1, 2023

Hello @ilhan007, thank you for using ui5-webcomponents-ngx! The ui5-webcomponents-ngx team will triage your issue as soon as possible.

@ilhan007
Copy link
Member Author

ilhan007 commented Nov 1, 2023

Hello @droshev this is one of the latest issues raised. Meanwhile I will ask the authors for more information. Thank you.

@ilhan007
Copy link
Member Author

ilhan007 commented Nov 9, 2023

Hello @timogeib

The following works for me with the ComboBox:

<ui5-combobox [formControl]="cbxControl">
		<ui5-cb-item value="phone" text="Phone"></ui5-cb-item>
		<ui5-cb-item value="tablet" text="Tablet"></ui5-cb-item>
		<ui5-cb-item value="desktop" text="Desktop"></ui5-cb-item>
 </ui5-combobox>
 FormControl value: {{ cbxControl.value }}, touched: {{ cbxControl.touched }}
<button (click)="updateCbxFormModel()">cbxControl.setValue("phone")</button>
import { Component } from '@angular/core';
import { FormControl, FormGroup } from '@angular/forms';

@Component({
  selector: 'reactive-form-sample',
  templateUrl: './reactiveFormSample.component.html',
})
export class ReactiveFormsSample {

  cbxControl = new FormControl('desktop');

  updateCbxFormModel() {
    this.cbxControl.setValue("phone");
  }
}
Screen.Recording.2023-11-09.at.18.59.18.mov

@timogeib
Copy link

@ilhan007
Please be aware of the touched flag, which will not be set to true...

@droshev droshev added this to the Sprint 127 milestone Nov 22, 2023
@g-cheishvili g-cheishvili added the Angular generator Topic related to the Angular Generator label Nov 23, 2023
@g-cheishvili
Copy link
Contributor

All works, except the fact that the value should be something. It can not be undefined or null and if that's the problem, the issue should be recorded in @ui5/webcomponents repository

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Angular generator Topic related to the Angular Generator SAP Build Process Automation
Projects
None yet
Development

No branches or pull requests

5 participants