Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Floating point binary indicators #15

Open
lupus83 opened this issue Sep 22, 2023 · 0 comments
Open

Floating point binary indicators #15

lupus83 opened this issue Sep 22, 2023 · 0 comments

Comments

@lupus83
Copy link

lupus83 commented Sep 22, 2023

Thanks for the amazing work!

I've noticed that you don't allow floating point indicators for binary variables, as '1.0' is not part of the allowed binary indicators in load_single_data

X[bin_cols] = X[bin_cols].astype(str).applymap(lambda x: 1 if x.lower() in ['yes','true','1','t'] else 0).values

It can certainly lead to unexpected behaviour and easily be fixed if desired.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant