Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"high" server thread % in Spark Profile #15

Open
peow opened this issue Feb 19, 2024 · 5 comments
Open

"high" server thread % in Spark Profile #15

peow opened this issue Feb 19, 2024 · 5 comments

Comments

@peow
Copy link

peow commented Feb 19, 2024

using Spark to see what is lagging my singleplayer modpack, Enchantment Plus appears almost at the top of the list which shows the mods with the highest percentage of Server Thread usage

image

profile link - https://spark.lucko.me/ivlxclnSjK

is this normal? has a way to decrease it?

@RobertHoueland
Copy link
Owner

Hm... that's not great to see. I suspect it is a high percentage because I have multiple checks for enchantments running each tick. I will see what I can do, but I would be surprised if it was actually causing a lot of lag.

@peow
Copy link
Author

peow commented Feb 23, 2024

ok, spark profiles don't last long, so I downloaded it and zipped it here if you need it
enchantment-spark.zip

to see the download file you need to drop it in the "Viewer"
https://spark.lucko.me/

If you are going to make an update, I ask you to update to 1.20.1

@RobertHoueland
Copy link
Owner

Sorry for the delayed response. Can you test removing Enchantments-Plus and see if you have a noticeable difference in lag? To ensure that the mod is causing the problems. (Making a backup of your world of course so you don't lose your enchantments)

@peow
Copy link
Author

peow commented May 3, 2024

you can't tell the difference, the percentage isn't very high, and in a game like Minecraft it's hard to benchmark, I just pointed out that the mod has a higher percentage than normal, other enchantment mods don't have as much Thread usage

@peow
Copy link
Author

peow commented May 3, 2024

image
I retested it on my modpack and this time it didn't give a bad result, so idk

I just wanted to point out the problem in case you think it's relevant

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants