You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The "std" feature for string-interner currently always enables "serde" when it is enabled, because the Cargo.toml says:
std = ["serde/std"]
instead of the correct:
std = ["serde?/std"]
which enables the "std" feature for serdeonly when"serde" is already enabled.
This currently means dependents of string-interner that set default-features = false while also enabling the "std" feature (expecting to only enable support for stdwithoutserde) may unknowingly depend on serde, taking a small amount of disk space (though I barely noticed any impact on compile times).
My current workaround is simply not enabling the "std" feature, and from my cursory glance of the source code, no code in string-interner itself currently uses anything from std, so this isn't too big of an issue.
The text was updated successfully, but these errors were encountered:
The
"std"
feature forstring-interner
currently always enables"serde"
when it is enabled, because theCargo.toml
says:instead of the correct:
which enables the
"std"
feature forserde
only when"serde"
is already enabled.This currently means dependents of
string-interner
that setdefault-features = false
while also enabling the"std"
feature (expecting to only enable support forstd
withoutserde
) may unknowingly depend onserde
, taking a small amount of disk space (though I barely noticed any impact on compile times).My current workaround is simply not enabling the
"std"
feature, and from my cursory glance of the source code, no code instring-interner
itself currently uses anything fromstd
, so this isn't too big of an issue.The text was updated successfully, but these errors were encountered: