Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Game crashing on malformed client commands #18

Open
AlexanderDzhoganov opened this issue Nov 25, 2015 · 2 comments
Open

Game crashing on malformed client commands #18

AlexanderDzhoganov opened this issue Nov 25, 2015 · 2 comments

Comments

@AlexanderDzhoganov
Copy link
Collaborator

It seems that it is pretty easy to crash the game by sending malformed commands. Maybe further development on the library should have a mechanism for validating commands before dispatching them to prevent this.

Discovered crashes so far:

  • UseItem with an invalid item ID - crash to desktop
  • UseItem with empty JSON - triggers assert
@rgbkrk
Copy link
Member

rgbkrk commented Nov 25, 2015

That's awesome. I wanted to try that to drop an item I didn't have, now we know the result.

Was it an arbitrary item ID or could you use an old item that isn't in your possession anymore (sold to a vendor)?

@maximegmd
Copy link

Hello,
Can you guys confirm this is a NULL pointer exception and/or provide a way to repro ?
Thanks !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants