Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: RisingStack/anchor
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v1.0.2
Choose a base ref
...
head repository: RisingStack/anchor
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: master
Choose a head ref
  • 4 commits
  • 4 files changed
  • 3 contributors

Commits on May 26, 2017

  1. Update pod.js 

    Dont cast to string when a tag is not defined.
    @keithballdotnet
    keithballdotnet authored May 26, 2017
    Copy the full SHA
    6df4552 View commit details

Commits on Jun 20, 2017

  1. fix(transformer/pod): Dont cast to string when a tag is not defined. (#2 

    )
    @hekike
    hekike authored Jun 20, 2017
    Copy the full SHA
    e400bb9 View commit details

  2. chore(package): update dependencies

    Peter Marton committed Jun 20, 2017
    Copy the full SHA
    aaae29d View commit details

  3. chore(package): bump version to 1.0.3

    Peter Marton committed Jun 20, 2017
    Copy the full SHA
    490a225 View commit details
Showing with 21 additions and 11 deletions.
  1. +8 −0 CHANGELOG.md
  2. +7 −7 package.json
  3. +2 −3 src/snapshot.js
  4. +4 −1 src/transform/pod.js
8 changes: 8 additions & 0 deletions CHANGELOG.md
View file
Original file line number Diff line number Diff line change
@@ -1,3 +1,11 @@
<a name="1.0.3"></a>
## 1.0.3 (2017-06-20)

* chore(package): update dependencies ([aaae29d](https://github.com/RisingStack/anchor/commit/aaae29d))
* Update pod.js ([6df4552](https://github.com/RisingStack/anchor/commit/6df4552))



<a name="1.0.2"></a>
## 1.0.2 (2017-05-23)

14 changes: 7 additions & 7 deletions package.json
View file
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@risingstack/anchor",
"version": "1.0.2",
"version": "1.0.3",
"description": "Creates Helm charts from Kubernetes resources.",
"main": "src/index.js",
"scripts": {
@@ -31,15 +31,15 @@
"rimraf": "2.6.1"
},
"devDependencies": {
"chai": "3.5.0",
"eslint": "3.19.0",
"chai": "4.0.2",
"eslint": "4.0.0",
"eslint-config-airbnb-base": "11.2.0",
"eslint-plugin-import": "2.2.0",
"eslint-plugin-import": "2.3.0",
"eslint-plugin-promise": "3.5.0",
"mocha": "3.4.1",
"mocha": "3.4.2",
"pre-commit": "1.2.2",
"sinon": "2.3.0",
"sinon-chai": "2.10.0"
"sinon": "2.3.5",
"sinon-chai": "2.11.0"
},
"pre-commit": [
"lint",
5 changes: 2 additions & 3 deletions src/snapshot.js
View file
Original file line number Diff line number Diff line change
@@ -47,8 +47,7 @@ function snapshot ({
[chartResource.scope]: chartResource.values
}
: chartResource.values
)
, {})
), {})

const saveTemplates = chartResources.map((chartResource) =>
chart.saveTemplate(outputPath, chartResource)
@@ -58,7 +57,7 @@ function snapshot ({
chart.saveValues(outputPath, values),
saveTemplates
])
.then(() => chartResources)
.then(() => chartResources)
})
}

5 changes: 4 additions & 1 deletion src/transform/pod.js
View file
Original file line number Diff line number Diff line change
@@ -30,7 +30,10 @@ function transformContainers (inputValues, inputChart, scope = '') {
const imageTag = tmp[1]

containerValues.image = image
containerValues.imageTag = imageTag.toString() // prevent casting to Number
if (imageTag) {
// prevent casting to Number
containerValues.imageTag = imageTag.toString()
}

container.image = `"{{ ${templateValuePathPrefix}.image }}:`
+ `{{ ${templateValuePathPrefix}.imageTag }}"`