From b81251664538f192c448ed6cefe0bb7b3d2262a3 Mon Sep 17 00:00:00 2001 From: bhimbho Date: Sat, 25 Jan 2025 03:24:02 +0100 Subject: [PATCH 1/3] fix: allow games with release date to be prioritized --- app/Platform/Concerns/BuildsGameListQueries.php | 1 + 1 file changed, 1 insertion(+) diff --git a/app/Platform/Concerns/BuildsGameListQueries.php b/app/Platform/Concerns/BuildsGameListQueries.php index b158b569e9..75ce358832 100644 --- a/app/Platform/Concerns/BuildsGameListQueries.php +++ b/app/Platform/Concerns/BuildsGameListQueries.php @@ -340,6 +340,7 @@ private function applyReleasedAtSorting(Builder $query, string $sortDirection = ELSE 4 END AS granularity_order SQL) + ->orderByRaw('released_at IS NULL') ->orderBy('normalized_released_at', $sortDirection) ->orderBy('granularity_order', $sortDirection); } From 559d5681a1f824b57c19fb25bdc4179de21ce63b Mon Sep 17 00:00:00 2001 From: bhimbho Date: Sat, 25 Jan 2025 03:34:40 +0100 Subject: [PATCH 2/3] remove whitespace --- app/Platform/Concerns/BuildsGameListQueries.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/Platform/Concerns/BuildsGameListQueries.php b/app/Platform/Concerns/BuildsGameListQueries.php index 75ce358832..7d587bf915 100644 --- a/app/Platform/Concerns/BuildsGameListQueries.php +++ b/app/Platform/Concerns/BuildsGameListQueries.php @@ -340,7 +340,7 @@ private function applyReleasedAtSorting(Builder $query, string $sortDirection = ELSE 4 END AS granularity_order SQL) - ->orderByRaw('released_at IS NULL') + ->orderByRaw('released_at IS NULL') ->orderBy('normalized_released_at', $sortDirection) ->orderBy('granularity_order', $sortDirection); } From cc271730f1843a7ebb75c4adcfa83654e3f120ef Mon Sep 17 00:00:00 2001 From: Soneye Oluwasina Abimbola Date: Sat, 25 Jan 2025 04:38:35 +0100 Subject: [PATCH 3/3] Update app/Platform/Concerns/BuildsGameListQueries.php Co-authored-by: Wes Copeland --- app/Platform/Concerns/BuildsGameListQueries.php | 1 + 1 file changed, 1 insertion(+) diff --git a/app/Platform/Concerns/BuildsGameListQueries.php b/app/Platform/Concerns/BuildsGameListQueries.php index 7d587bf915..a537374826 100644 --- a/app/Platform/Concerns/BuildsGameListQueries.php +++ b/app/Platform/Concerns/BuildsGameListQueries.php @@ -340,6 +340,7 @@ private function applyReleasedAtSorting(Builder $query, string $sortDirection = ELSE 4 END AS granularity_order SQL) + // Ensure NULL release dates always sort to the end, regardless of sort direction. ->orderByRaw('released_at IS NULL') ->orderBy('normalized_released_at', $sortDirection) ->orderBy('granularity_order', $sortDirection);