Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix linking local RN SDK packages into the web-components repo #51

Open
MantisClone opened this issue Nov 12, 2024 · 2 comments · May be fixed by RequestNetwork/web-components#244
Open

Comments

@MantisClone
Copy link
Member

MantisClone commented Nov 12, 2024

Problem

Multiple RN devs have experienced difficulty linking local packages.

  • Link RN SDK packages into web-components
  • Link web-components into invoicing-template

Investigation required.

Bandaid Solution

Copy/paste the dist/ folder works, but it's prone to human error.

Theories

  • Linking pulls in extra directories that it shouldn't. Maybe there's a way to configure the npm link command to exclude a directory.
  • Linking multiple levels fails but single level works
  • web-components is monorepo so location to run link command depends on whether the dependency is specific to the package, or shared with multiple packages.
@MantisClone MantisClone converted this from a draft issue Nov 12, 2024
@MantisClone MantisClone moved this from 🆕 New to 🎫 Backlog in Request Network Tech Backlog Nov 12, 2024
@MantisClone
Copy link
Member Author

Consider using symlinkr tool developed by @aimensahnoun

@MantisClone
Copy link
Member Author

Maybe fixed by RequestNetwork/web-components#244? @rodrigopavezi to confirm.

@MantisClone MantisClone linked a pull request Jan 8, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🎫 Backlog
Development

Successfully merging a pull request may close this issue.

1 participant