Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add array store bytecode case (and others) #4

Open
franz1981 opened this issue Nov 2, 2022 · 0 comments
Open

Add array store bytecode case (and others) #4

franz1981 opened this issue Nov 2, 2022 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@franz1981
Copy link
Contributor

franz1981 commented Nov 2, 2022

According to https://github.com/openjdk/jdk11/blob/37115c8ea4aff13a8148ee2b8832b20888a5d880/src/hotspot/share/opto/graphKit.cpp#L3010 array store bytecode produce checkcast type checks as well and should be accounted by the agent, if makes sense.

Reflective calls too but it doesn't seem possible to include that one too.

https://github.com/openjdk/jdk11/blob/37115c8ea4aff13a8148ee2b8832b20888a5d880/src/hotspot/cpu/x86/methodHandles_x86.cpp#L370 could be another one, but requires further investigations.

Speaking with @simonis re openjdk/jdk#6434 it doesn't seem related to just instanceof/checkcast too, but invokespecial: I'm now digging on the JDK src code to understand how/if it's possible to include them somehow.

@franz1981 franz1981 self-assigned this Nov 2, 2022
@franz1981 franz1981 added the enhancement New feature or request label Nov 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant