Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert header menu to be API based to avoid it not being generated #271

Open
RealRaven2000 opened this issue Oct 30, 2023 · 3 comments
Open
Assignees
Labels
ESR 115 Changes for Thunderbird SuperNova UI

Comments

@RealRaven2000
Copy link
Owner

Normally the SmartTemplates button on top of the email preview shows the reply and forward menus. I have seen this arbitrarily not filled with data, leading to an empty menu:

image

@RealRaven2000 RealRaven2000 added the ESR 115 Changes for Thunderbird SuperNova UI label Oct 30, 2023
@RealRaven2000 RealRaven2000 self-assigned this Oct 30, 2023
@RealRaven2000
Copy link
Owner Author

A current workaround for this is delaying the patch of the header area by increasing the value in

extensions.smartTemplate4.fileTemplates.menus.delayMessagePane

try 10000 (10 seconds) to start with

RealRaven2000 added a commit that referenced this issue Nov 8, 2023
@RealRaven2000 RealRaven2000 changed the title When starting Tb with multiple tabs, sometimes the header menu is empty Convert header menu to be API based to avoid it not being generated Feb 22, 2024
@RealRaven2000 RealRaven2000 pinned this issue Feb 22, 2024
RealRaven2000 added a commit that referenced this issue Mar 10, 2024
@RealRaven2000
Copy link
Owner Author

As an interim solution, I made the menu patching more stable by removing the injection code that is based on the menupopup ids (and inject an invisible <div> instead which contains the desired menu structure). I have also started writing test code for building the new menu via the API, which will be located on the test menu:

image

new version for testing, appears to be stable at the moment:

smartTemplate-fx-4.4pre94.zip


To test the version above, download the zip file, drag the file into Thunderbird Add-ons Manager, do not extract contents or if won't install.

@RealRaven2000
Copy link
Owner Author

For the latest versions see #253, or use this one:

smartTemplate-fx-4.4pre144.zip

@RealRaven2000 RealRaven2000 unpinned this issue Mar 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ESR 115 Changes for Thunderbird SuperNova UI
Projects
None yet
Development

No branches or pull requests

1 participant