Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Establish standard coding practice for APL writing #93

Open
RosvallM opened this issue Jan 29, 2018 · 0 comments
Open

Establish standard coding practice for APL writing #93

RosvallM opened this issue Jan 29, 2018 · 0 comments
Labels

Comments

@RosvallM
Copy link

RosvallM commented Jan 29, 2018

Thesis:
There are several benefits in establishing a standard coding best practice for APL writing.

Background:
During Legion we have encountered a significant increase in class configurations. Where we previously almost only had to plan for talent set up and tier set bonuses, we now also have needed to take legendaries and artifact traits into account. Additionally; with different balancing and talents that impact playstyle more we can assume that classes in the future will use a larger spread of talents.

By reworking how APL's are written we can reap several benefits.
Most obvious it will increase readability. F.ex by ordering constraints in: "Talents, Set bonus, Items", readability will be increased.

Moving from complex and long constraint lists to split up rows will also increase readability as well as make fault searching in the reports, under Action Priority List section easier. It also helps identifying redundant rows that never gets parsed and enables one to easily compile shorter but more specific APL's if desired.

Furthermore clean easily readable code will lower the barrier of entry and perhaps increase participation in APL editing and improvement and possibly in the future for creating a playstyle guide directly from SimulationCraft result report.

@Mystler Mystler added the SimC label Jan 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants