Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactors corner plot #332

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

StephenNneji
Copy link
Collaborator

@StephenNneji StephenNneji commented Jan 24, 2025

Fixes #329

This fixes issues with the corner plot axis and adds a smooth argument which was already used in the live scripts. Also removes hist3 usage (fixes #146)

cornerPlot

The suggested replacement (TiledCovariancePlotv2) works with a few changes but is about 2x slower than the current one so probably not worth using

@arwelHughes
Copy link
Collaborator

arwelHughes commented Jan 24, 2025 via email

@arwelHughes
Copy link
Collaborator

arwelHughes commented Jan 24, 2025 via email

@alexhroom
Copy link
Collaborator

cornerPlot
here's the old plotting for reference... @arwelHughes could you elaborate on what you think looks a bit horrible about it? I can't really see a difference between it and the old plots

@alexhroom
Copy link
Collaborator

one thing I will note is that the aspect ratio seems a bit funny - we'd usually expect each item in the plot to be square, but i don't know if that's just how it's been scaled in this specific case

@StephenNneji
Copy link
Collaborator Author

one thing I will note is that the aspect ratio seems a bit funny - we'd usually expect each item in the plot to be square, but i don't know if that's just how it's been scaled in this specific case

The aspect ratio is square when it draws initially but it does not preserve the ratio when the figure is scaled just like the former

@StephenNneji
Copy link
Collaborator Author

Ideally, we'd love to fit ellipses (as an option), but I've never worked out how! e.g. [Learned harmonic mean estimation of the Bayesian evidence with normalizing flows]

@arwelHughes we can look at this as a future issue but please let us know what looks horrible? The major issue was that 2 different axes were being drawn on the top left and bottom right of the plot. We could revert the code and fix only this if you feel confident the plot has changed?

@StephenNneji
Copy link
Collaborator Author

StephenNneji commented Jan 27, 2025

Screenshot 2025-01-27 111525
@arwelHughes This is a side by side of both plots the new is on the left and the old is on the right

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace cornerPlot Remove dependence on Statistical Toolbox
3 participants