-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactors corner plot #332
base: master
Are you sure you want to change the base?
Refactors corner plot #332
Conversation
Erm.... That looks a bit horrible.
I'm used to something like this....
[cid:9683fd94-201d-488c-ae18-dc81c83d4bb2]
…________________________________
From: StephenNneji ***@***.***>
Sent: Friday, January 24, 2025 11:26 AM
To: RascalSoftware/RAT ***@***.***>
Cc: Subscribed ***@***.***>
Subject: [RascalSoftware/RAT] Refactors corner plot (PR #332)
Fixes #329<#329>
This fixes issues with the corner plot axis and adds a smooth argument which was already used in the live scripts
cornerPlot.png (view on web)<https://github.com/user-attachments/assets/68384e5e-3a29-403b-87cb-1c9359bd956b>
The suggested replacement (TiledCovariancePlotv2) works with a few changes but is about 2x slower than the current one so probably not worth using
________________________________
You can view, comment on, or merge this pull request online at:
#332
Commit Summary
* ba33aba<ba33aba> Refactors corner plot
* 3a5710b<3a5710b> Updates live script plots
File Changes
(7 files<https://github.com/RascalSoftware/RAT/pull/332/files>)
* M examples/miscellaneous/convertRascal1Project/convertRascal.mlx<https://github.com/RascalSoftware/RAT/pull/332/files#diff-84ec409f99cff8c94499472e9c73d323bf8d7b51a1558e8ea27f854414214eb4> (0)
* M examples/normalReflectivity/customLayers/customLayersDSPCSheet.mlx<https://github.com/RascalSoftware/RAT/pull/332/files#diff-3ca88723b5e0f9c1c42f27e2c131f875eeb41f565408325a9940a61c601210bf> (0)
* M examples/normalReflectivity/customXY/customXYDSPCSheet.mlx<https://github.com/RascalSoftware/RAT/pull/332/files#diff-569a9bed98c7e5f9f3885d71083478a0c3ac142d204647d4a21a7a8bc82610c1> (0)
* M examples/normalReflectivity/standardLayers/standardLayersDSPCSheet.mlx<https://github.com/RascalSoftware/RAT/pull/332/files#diff-cdc6c8d9c0e8fcc135693852afd0f8f2761a744894b89f952344f376bccec795> (0)
* A utilities/isFigure.m<https://github.com/RascalSoftware/RAT/pull/332/files#diff-a962e897278d991457a8f49587da28670ac3f7c574bc0dcc11b730ef6176b306> (6)
* M utilities/plotting/cornerPlot.m<https://github.com/RascalSoftware/RAT/pull/332/files#diff-6090f8066bf0323a3d56462ba534b90497180a04d8901f1eb65f650198dda854> (377)
* M utilities/plotting/plotHists.m<https://github.com/RascalSoftware/RAT/pull/332/files#diff-dba521e7d02389360aca774e49ab8551cfb1eca51b1aa7853b60ca81fd59cb94> (6)
Patch Links:
* https://github.com/RascalSoftware/RAT/pull/332.patch
* https://github.com/RascalSoftware/RAT/pull/332.diff
—
Reply to this email directly, view it on GitHub<#332>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AGMNVXQ6ZPLAO4KME27RR3D2MIPOVAVCNFSM6AAAAABVZO4TQWVHI2DSMVQWIX3LMV43ASLTON2WKOZSHAYDSMRQGU2DCMI>.
You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>
|
Ideally, we'd love to fit ellipses (as an option), but I've never worked out how! e.g.
[Learned harmonic mean estimation of the Bayesian evidence with normalizing flows]
…________________________________
From: Hughes, Arwel (STFC,RAL,ISIS) ***@***.***>
Sent: Friday, January 24, 2025 2:38 PM
To: RascalSoftware/RAT ***@***.***>; RascalSoftware/RAT ***@***.***>
Cc: Subscribed ***@***.***>
Subject: Re: [RascalSoftware/RAT] Refactors corner plot (PR #332)
Erm.... That looks a bit horrible.
I'm used to something like this....
[cid:9683fd94-201d-488c-ae18-dc81c83d4bb2]
________________________________
From: StephenNneji ***@***.***>
Sent: Friday, January 24, 2025 11:26 AM
To: RascalSoftware/RAT ***@***.***>
Cc: Subscribed ***@***.***>
Subject: [RascalSoftware/RAT] Refactors corner plot (PR #332)
Fixes #329<#329>
This fixes issues with the corner plot axis and adds a smooth argument which was already used in the live scripts
cornerPlot.png (view on web)<https://github.com/user-attachments/assets/68384e5e-3a29-403b-87cb-1c9359bd956b>
The suggested replacement (TiledCovariancePlotv2) works with a few changes but is about 2x slower than the current one so probably not worth using
________________________________
You can view, comment on, or merge this pull request online at:
#332
Commit Summary
* ba33aba<ba33aba> Refactors corner plot
* 3a5710b<3a5710b> Updates live script plots
File Changes
(7 files<https://github.com/RascalSoftware/RAT/pull/332/files>)
* M examples/miscellaneous/convertRascal1Project/convertRascal.mlx<https://github.com/RascalSoftware/RAT/pull/332/files#diff-84ec409f99cff8c94499472e9c73d323bf8d7b51a1558e8ea27f854414214eb4> (0)
* M examples/normalReflectivity/customLayers/customLayersDSPCSheet.mlx<https://github.com/RascalSoftware/RAT/pull/332/files#diff-3ca88723b5e0f9c1c42f27e2c131f875eeb41f565408325a9940a61c601210bf> (0)
* M examples/normalReflectivity/customXY/customXYDSPCSheet.mlx<https://github.com/RascalSoftware/RAT/pull/332/files#diff-569a9bed98c7e5f9f3885d71083478a0c3ac142d204647d4a21a7a8bc82610c1> (0)
* M examples/normalReflectivity/standardLayers/standardLayersDSPCSheet.mlx<https://github.com/RascalSoftware/RAT/pull/332/files#diff-cdc6c8d9c0e8fcc135693852afd0f8f2761a744894b89f952344f376bccec795> (0)
* A utilities/isFigure.m<https://github.com/RascalSoftware/RAT/pull/332/files#diff-a962e897278d991457a8f49587da28670ac3f7c574bc0dcc11b730ef6176b306> (6)
* M utilities/plotting/cornerPlot.m<https://github.com/RascalSoftware/RAT/pull/332/files#diff-6090f8066bf0323a3d56462ba534b90497180a04d8901f1eb65f650198dda854> (377)
* M utilities/plotting/plotHists.m<https://github.com/RascalSoftware/RAT/pull/332/files#diff-dba521e7d02389360aca774e49ab8551cfb1eca51b1aa7853b60ca81fd59cb94> (6)
Patch Links:
* https://github.com/RascalSoftware/RAT/pull/332.patch
* https://github.com/RascalSoftware/RAT/pull/332.diff
—
Reply to this email directly, view it on GitHub<#332>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AGMNVXQ6ZPLAO4KME27RR3D2MIPOVAVCNFSM6AAAAABVZO4TQWVHI2DSMVQWIX3LMV43ASLTON2WKOZSHAYDSMRQGU2DCMI>.
You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>
|
|
one thing I will note is that the aspect ratio seems a bit funny - we'd usually expect each item in the plot to be square, but i don't know if that's just how it's been scaled in this specific case |
The aspect ratio is square when it draws initially but it does not preserve the ratio when the figure is scaled just like the former |
|
|
Fixes #329
This fixes issues with the corner plot axis and adds a smooth argument which was already used in the live scripts. Also removes
hist3
usage (fixes #146)The suggested replacement (TiledCovariancePlotv2) works with a few changes but is about 2x slower than the current one so probably not worth using