From 832fa3fff8411ac164440c79c9dc7df3a32a2b62 Mon Sep 17 00:00:00 2001 From: ramaID Date: Sat, 22 Jun 2024 14:05:56 +0700 Subject: [PATCH 1/2] fix: abstract class BaseRequest --- src/Bases/BaseRequest.php | 19 ++++++++----------- 1 file changed, 8 insertions(+), 11 deletions(-) diff --git a/src/Bases/BaseRequest.php b/src/Bases/BaseRequest.php index 88293f4..cf5c306 100644 --- a/src/Bases/BaseRequest.php +++ b/src/Bases/BaseRequest.php @@ -6,7 +6,7 @@ use Illuminate\Foundation\Http\FormRequest; -class BaseRequest extends FormRequest +abstract class BaseRequest extends FormRequest { /** * Determine if the user is authorized to make this request. @@ -21,15 +21,12 @@ public function authorize(): bool * * @return array|string> */ - public function rules(): array - { - return [ - // - ]; - } + abstract public function rules(): array; - public function toDto() - { - return BaseData::from(...$this->all()); - } + /** + * Convert the request to a DTO. + * + * @return BaseData + */ + abstract public function toDto(): BaseData; } From d7a68b3e9d6f2dbb6b34f4506a1b4332d102b24d Mon Sep 17 00:00:00 2001 From: ramaID Date: Sat, 22 Jun 2024 07:06:22 +0000 Subject: [PATCH 2/2] Fix styling --- src/Bases/BaseData.php | 4 +--- src/Bases/BaseRequest.php | 2 -- src/LaravelRestify.php | 4 +--- 3 files changed, 2 insertions(+), 8 deletions(-) diff --git a/src/Bases/BaseData.php b/src/Bases/BaseData.php index 45a4a43..f8b94ae 100644 --- a/src/Bases/BaseData.php +++ b/src/Bases/BaseData.php @@ -4,6 +4,4 @@ namespace RapidKit\LaravelRestify\Bases; -class BaseData extends \Spatie\LaravelData\Data -{ -} +class BaseData extends \Spatie\LaravelData\Data {} diff --git a/src/Bases/BaseRequest.php b/src/Bases/BaseRequest.php index cf5c306..201a49d 100644 --- a/src/Bases/BaseRequest.php +++ b/src/Bases/BaseRequest.php @@ -25,8 +25,6 @@ abstract public function rules(): array; /** * Convert the request to a DTO. - * - * @return BaseData */ abstract public function toDto(): BaseData; } diff --git a/src/LaravelRestify.php b/src/LaravelRestify.php index 8f5d816..344c427 100755 --- a/src/LaravelRestify.php +++ b/src/LaravelRestify.php @@ -2,6 +2,4 @@ namespace RapidKit\LaravelRestify; -class LaravelRestify -{ -} +class LaravelRestify {}