Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feed not found #4521

Open
peterbozso opened this issue Feb 8, 2025 · 4 comments
Open

Feed not found #4521

peterbozso opened this issue Feb 8, 2025 · 4 comments

Comments

@peterbozso
Copy link

First: really cool project. Thank you very much for making these apps available for free!

Second: my issue.
I have my blog: https://blog.bozso.dev
Which has its feed available at: https://blog.bozso.dev/feed.xml
I reference that feed in the <head> of each page like this:

<link rel="alternate" type="application/atom+xml" href="/feed.xml">

But for some reason, NetNewsWire (6.1.9 on MacOS) can't add the feed when I give it only the URL of my blog (https://blog.bozso.dev). It has no issues when I give it the direct URL of the feed file (https://blog.bozso.dev/feed.xml).

Both Feedly and feedreader.com are okay with just https://blog.bozso.dev, they can add the feed from that URL all right.

Is it a bug in NetNewsWire that makes it fail to identify my feed or is there something I am doing wrong in the code of my website?

@brentsimmons
Copy link
Collaborator

It’s because the HTML for the blog doesn’t include a body tag. NetNewsWire looks for (case-insensitive) html and body tags to determine if a given document is HTML.

If you would suggest that NetNewsWire’s heuristics could be improved here, I’d agree. False negatives and false positives are too easy.

@brentsimmons brentsimmons added this to the NetNewsWire 6.3 milestone Feb 8, 2025
@peterbozso
Copy link
Author

Ah, okay, gotcha, thanks! I completely forgot that I am minifying those out of the final HTML files (like this). Since other feed readers (at least the ones I've tried and mentioned above) are fine with it, and according to the HTML5 specification it's okay to omit them, I'd say it'd be nice if NetNewsWire could also handle HTMLs like this.

But! In order to not just be demanding features for free: could you please point me towards the part of the codebase of NetNewsWire that handles this? I've never written a line of Swift myself (coming from .NET/TypeScript/Go background), but I would be more than happy to give it a try and submit a patch for this.

@brentsimmons
Copy link
Collaborator

Thanks for the offer! But this is going to take more thought than just dropping the check for the body tag — we need a good set of rules that minimizes false negatives and positives. Requires research and thinking and testing.

@peterbozso
Copy link
Author

I see. Nevertheless, if you need help with that, my offer stands. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants