Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mrss "media" namespace tags not imported by FeedExpander #4415

Closed
Phantop opened this issue Jan 24, 2025 · 1 comment · Fixed by #4422
Closed

Mrss "media" namespace tags not imported by FeedExpander #4415

Phantop opened this issue Jan 24, 2025 · 1 comment · Fixed by #4422
Labels
Bug-Report Confirmed bug report

Comments

@Phantop
Copy link
Contributor

Phantop commented Jan 24, 2025

To be more precise, see this example feed.

I'm working on a new YouTube bridge, trying to add some functionality not in the existing one while also aiming to make a less complex bridge by letting FeedExpander do most of the work. A small caveat is that the entry description is located in a media:description tag under a media:group tag.

Taking a look at the code, I noticed that the media namespace is explicitly not included, as well as this code and comment in FeedParser. I attached a diff that does allow for these elements to be picked up and added, however I'm not opening that as a PR as I'm concerned about their inclusion breaking other feeds. I'm hoping for some discussion to enable these tags to be imported.

feedparser.diff

@Phantop Phantop added the Bug-Report Confirmed bug report label Jan 24, 2025
@dvikan
Copy link
Contributor

dvikan commented Jan 25, 2025

Some time ago, I tried adding parsing of media module from youtube but I failed. would be nice if we could do that

im also concerned about breaking feeds.

need also to remember that the output from FeedParser is used by AtomFormat, JsonFormat etc,

i think it's going to be hard to generically parse rss modules but we could explicitly add parsing logic only for youtube

EDIT: there are some unit tests for FeedParser, which is nice

EDIT: example of manual hand parsing of yt feed: http://www.marcogoncalves.com/parsing-media-rss-with-php-simplexml/

dvikan added a commit to dvikan/rss-bridge that referenced this issue Jan 25, 2025
Also stop excluding the media module

fix RSS-Bridge#4415
@dvikan dvikan closed this as completed in dd8bc07 Jan 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug-Report Confirmed bug report
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants